If I am on mysite.com/file/1/edit?destination=foo/bar%3Fvar1%3Dxxx then the cancel button does not work properly because the query string from destination is encoded when it is included in the #href property of the $form['cancel'] element. Thats a bit of a mouth-full, but basically we need to split up the query string
and path from the destination.

Note: My real-world case here is that I created a view of files with exposed filters and an edit link in order to customize the table found at /admin/content/file

Files: 
CommentFileSizeAuthor
#2 file-entity-cancel.patch980 bytesbleen18
PASSED: [[SimpleTest]]: [MySQL] 874 pass(es).
[ View ]
#1 fiel-entity-cancel.patch979 bytesbleen18
PASSED: [[SimpleTest]]: [MySQL] 829 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new979 bytes
PASSED: [[SimpleTest]]: [MySQL] 829 pass(es).
[ View ]

...and here is a patch

StatusFileSize
new980 bytes
PASSED: [[SimpleTest]]: [MySQL] 874 pass(es).
[ View ]

... and here is a patch without the spelling error in the comment

Status:Needs review» Reviewed & tested by the community

Works as advertised.

#2: file-entity-cancel.patch queued for re-testing.

Status:Reviewed & tested by the community» Fixed

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.