After joining group it is unclear why you can't post - should say Pending approval

Excellent point! Thanks for the suggestion.

Moving to the "Groups" component.

The referenced text is actually new as of 3.3 with the intention of making this more clear. Marking for triage in the 3.3 radar.

The attached patch changes the pending membership to displaying the text "Your membership request is pending review by a group organizer" as a non-link.

Very happy to see this issue on the table.

On a related note, for groups that hide contributed content from non-members, the commons browsing widget says things like "There are no posts to display" when it would be more helpful to say "You do not have access to view this content." Should I create a separate issue for that?

@behoppe333 Thanks. Are you able to review the patch?

Yes, please create a new issue for your suggestion. Thanks!

@ezra-g, yes -- with some coaching I will be able to review the patch. Last week I managed to apply my first patch with help from devincarlson :-)

The coaching is about how best to arrange my instance (or instances?) of Drupal Commons so that I can both (1) create a new site from scratch intended for production launch soon after release of C3.3 and (2) test the latest dev code so that C3.3 is as awesome as possible. I would prefer to manage a single instance of Drupal Commons, but I am struggling. It seems like patches require me to have local git repos for each relevant project (e.g., Commons Documents, Commons Groups, etc) and those (it seems) sit squarely inside the destination folders where my "drush make" rebuilds go. I am also trying to establish a baseline site DB (i.e., my soon-to-be-production C3.3 site) and I am not sure if it's reasonable to do that and each day (or week) update the code that sits on top of that DB.

(At risk of TMI, here are reasons why I am trying to do all those at once: I am simultaneously (a) creating a brand new community site for my company, (b) planning to use Commons 3.3 for that community site, (c) using Commons 7.x-3.x-dev to create mock-ups for key stakeholders of the new site, (d) establishing baseline Drupal settings/DB for the new site, (e) testing Commons 7.x-3.x-dev, and (f) learning Drupal, drush, and git as fast as I can.)

I have done very simple test of patch in #2 and it looks good, btw. :-)

#2 is committed: http://drupalcode.org/project/commons_groups.git/commit/4a64bb1.

@behoppe333, We'd be happy to discuss your development workflow in a new issue. Thanks!

I created a fresh instance of Commons from scratch on July 9 and this bug has resurfaced. I verified that my instance has the commit from #7. I could be wrong but my hunch is funky interaction happening between recent commits:

• Issue #2037393 by Devin Carlson: Display join group...
• Issue #2037417 by japerry: Add og group type filters...
• Issue #2020247 by ezra-g, RobKoberg: After joining...

I too can reproduce this using the steps in https://drupal.org/node/2019057#comment-7561585 (#17). It just says 'join group' even though the code is in there.

Updating groups git to this:
http://drupalcode.org/project/commons_groups.git/commit/771a331e25cbec3d...

Causes this error to come back.

Fixed the regression caused in the previous commit. this should be fixed now!

http://drupalcode.org/project/commons_groups.git/commit/9b2e4fe

works for me too. thanks :-)