Files: 
CommentFileSizeAuthor
#11 vdc-2020859-11.patch2.92 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 56,168 pass(es).
[ View ]
#7 2020859-human_name-to-label-6.patch2.82 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 57,723 pass(es).
[ View ]
#7 2020859-diff-1-6.txt2.38 KBvijaycs85
#1 2020859-human_name-to-label-1.patch455 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 57,733 pass(es).
[ View ]

Comments

Issue tags:+Quick fix
StatusFileSize
new455 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,733 pass(es).
[ View ]

Initial patch...

Currently it is failing few test cases in #1952394-45: Add configuration translation user interface module in core

Status:Active» Needs review
Issue tags:-Quick fix

Issue tags:+Quick fix

Status:Needs review» Reviewed & tested by the community

Oh right I should have spotted that.

Do we want to fix it in these as well?

  • core/modules/tracker/tests/modules/tracker_test_views/test_views/views.view.test_tracker_user_uid.yml
  • core/modules/views/tests/views_test_config/test_views/views.view.test_page_display_arguments.yml
  • core/modules/views/tests/views_test_config/test_views/views.view.test_page_view.yml
  • core/modules/views/tests/views_test_config/test_views/views.view.test_page_display_route.yml

We are still getting exceptions,
341 passes, 0 fails, 4 exceptions, and 118 debug messages,
in config_translation (with these applied:
#2020867: Update contact module URL in test cases.
#2020347: Temporary fix for config_translation_enter_context until language context becomes an option
#2020343: remove instance of locale_storage()
#2020859: Change the occurance of 'human_name' to 'label' in views configuration & schema
)
http://screencast.com/t/vizSwnFKL
Undefined index: source
http://screencast.com/t/s4Oh3E8lTbUb

I'm not sure if those are causing the exceptions through. Or totally unrelated.

Note, #1952394: Add configuration translation user interface module in core will add tests that rely on schema so provides some test coverage of schema.

Title: Change 'human_name' to 'label' in views schema Change the occurance of 'human_name' to 'label' in views configuration & schema
Status:Reviewed & tested by the community» Needs review
StatusFileSize
new2.38 KB
new2.82 KB
PASSED: [[SimpleTest]]: [MySQL] 57,723 pass(es).
[ View ]

Yes, Updated them all and title to reflect the patch changes... back to 'Needs review'.

Oh, I see. sorry, those were config changes just for human name still, nothing else.
Which probably answers my question that it's not related to the other exceptions.

---
with patch applied,
$ ag human_name core
core/modules/field_ui/lib/Drupal/field_ui/DisplayOverview.php
150: 'human_name' => array(
334: 'human_name' => array(

So no more human_name in views.
Changes look good to me.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

Looks simple enough, but no longer applies.

Title: Change the occurance of 'human_name' to 'label' in views configuration & schemaChange the occurance of 'human_name' to 'label' in views configuration & schema
Status:Needs work» Needs review
StatusFileSize
new2.92 KB
PASSED: [[SimpleTest]]: [MySQL] 56,168 pass(es).
[ View ]

Was just a new directory added.

Status:Needs review» Needs work
Issue tags:-Quick fix, -VDC

The last submitted patch, vdc-2020859-11.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Quick fix, +VDC

#11: vdc-2020859-11.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Can confirm there are no traces of human_name in views, views_ui or any views YAML...

Committed 5356a24 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.