Add a ConfigFactoryInterface for ConfigFactory

4: config-2021111-4.patch queued for re-testing.

Reroll and some more fixes.

Here is the fix. Fails shows the benefit of having interface :D

This fixes Configfactory into interface, no api changes here

9: config-2021111-9.patch queued for re-testing.

Simple reroll.

Needs roll after #2163371: Replace \Drupal:config()->get with ConfigFactory::loadMultiple in Drupal\Core\Config\Entity\Query.

Here's a re-roll

Giving Alex a chance to look at this before it goes in, makes sense to me although it could conflict with quite a lot.

15: config-2021111-15.patch queued for re-testing.

Once more patch needs reroll. Please add 'Avoid commit conflicts' once RTBC and assign back it to @alexpott. Thank you @catch for having the look and @mtift for the reroll.

Postponing on #2098119: Replace config context system with baked-in locale support and single-event based overrides

Personally I think we should do this in two steps - get the interface in and the config factory using it - and then do the type hinting changes.

Here is step 1. Please review I have created the patch from scratch.

+++ b/core/lib/Drupal/Core/Config/ConfigFactory.php
@@ -24,12 +24,7 @@
+class ConfigFactory implements ConfigFactoryInterface,EventSubscriberInterface {

Very minor - missing a space after the comma. Otherwise looks good.

+++ b/core/lib/Drupal/Core/Config/ConfigFactoryInterface.php
@@ -0,0 +1,176 @@
+  /**
+   * Removes stale static cache entries when configuration is saved.
+   *
+   * @param ConfigEvent $event
+   *   The configuration event.
+   */
+  public function onConfigSave(ConfigEvent $event);

This is an event function should I remove it form interface?

#23 yep that is a good point.

Here we go.

+++ b/core/lib/Drupal/Core/Config/ConfigFactory.php
@@ -445,10 +359,7 @@ protected function canOverride($name) {
   /**
-   * Removes stale static cache entries when configuration is saved.
-   *
-   * @param ConfigEvent $event
-   *   The configuration event.
+   * {@inheritdoc}
    */
   public function onConfigSave(ConfigEvent $event) {

Needs reverting too :)

My bad. Fixed

+++ b/core/lib/Drupal/Core/Config/ConfigFactory.php
@@ -2,7 +2,7 @@
+ * Contains of Drupal\Core\Config\ConfigFactory.

Should be Contains \Drupal\Core\Config\ConfigFactory.

srlsy NW :P. Fixed.

Looks great - thanks!

Needs reroll - conflicts with #2108599: Convert language_default to CMI

git ac https://drupal.org/files/issues/config-2021111-29.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11368  100 11368    0     0   5045      0  0:00:02  0:00:02 --:--:--  6263
error: patch failed: core/lib/Drupal/Core/Config/ConfigFactory.php:360
error: core/lib/Drupal/Core/Config/ConfigFactory.php: patch does not apply

Reroll

postponing on #2172561: Config overrides may spill over to undesired places - this patch is just going to go through re-roll hell :(

Here we go again. With minor doc fixes.

I can't think of any other rtbc patches that are doing anything to the ConfigFactory so this one should be good to go!

Thanks for sticking with @jibran

34: config-2021111-34.patch queued for re-testing.

Back to RTBC then.

Committed f1fdcfa and pushed to 8.x. Thanks!

#2184231: Use ConfigFactoryInterface to type hint ConfigFactory added as a child issue. Thanks everyone. Thank you @alexpott for the commit.