I was looking at possibly using this module for a Drupal 8 project coming down the pipeline. Having spent a lot of time looking at core and how things have changed from Drupal 7 thought I would make some suggestions. The first is that the OAuth class satisfies the requirements of being managed via package manager or composer. The second is to define the OAuth class as a service exposed/managed via the DI container. These two things seem to patterns prevalent throughout the Drupal 8 architecture and seem very applicable here. Just a thought.

Comments

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Active » Closed (won't fix)

Thanks for the suggestion, however, I started using PECL's OAuth library at #2027863: Make Oauth module an AuthenticationProvider and so far the first attempt has been successful. This makes that we won't need lib/OAuth.php classes anymore which is great since we will rely in a third party package instead of maintaining our own implementation.