Filter by view mode

Patch in #1 works as advertised.

#1 Works great. Thanks! Marking RTBC

I have updated the patch to work with latest dev version of the module. There was a commit which added the view mode context condition in Decemeber http://cgit.drupalcode.org/context_entity_field/commit/?id=81f9108 but this patch seems to work better. Now there are two ways to choose a "Entity view mode" condition. These should be merged into the latest dev version.

Here is an updated patch. It removes the view mode plugin, because in the patched version the view mode selection is in the same entity field plugin.

In my experience this patched version works better, because it will check an entity, for example in a view, to have both the view mode AND some field value, before the context condition is met. When those two are separated, it's possible that another entity will make the other context condition pass, and another entity the other one.

Will probably need some update to tests and possible an update hook, which I'm not sure how to do. Changing to "Needs review" for testing.

Because there is a change in the info file, this can be only applied by pulling the latest version with git.

Hi guys, thank you for the effort on this patch, my plan is to complete the testing part and release 7.x-1.1 ASAP, then integrate other patch.. sorry for delay :(

If someone is interested to help me on the test development let me know.

#5 is working for me. Thanks.

I agree that the view mode filtering needs to be part of "context_condition_entity_field" instead of a separate plugin. While I could probably setup contexts in the proper AND/OR configurations I would require, it would be a pain. Integrating them makes this a LOT easier.

Here is an updated version of patch #5 that consolidates handling of settings (and default values), does some extra value filtering, and adds additional descriptive text to the new view-mode filter. It's essentially the same as that in #5, but fixes some general issues with how the settings array is handled.

The patch from #2205345-4: Latest dev doesn't respect old settings has the same handling of settings. My hope is that aligning things this way will make it easier to get these two tickets into the dev branch.

There is an issue in the patch in #8 which when composing the options array to choose the view mode the keys are overwritten by later iterations. So for example it isn't possible to choose 'Full content (Content)' as 'Full content (User)' overwrites it as they share the same key 'full'. This patch introduces the entity type prepended with a colon before the view mode machine name as the key and therefore allows all view modes to be chosen. There execute handler is modified to assemble the key from the $entity_type and the $view_name.

Otherwise the patch seems to be doing what I expect and is working nicely. Thanks!

I tested and can confirm that patch #9 works
This solution is a lot better than the current solution on the 7.x-1.x dev branch, which BTW has a bug:

The execution of entity_view_mode plugin should happen before the execution of entity_field plugin:

function context_entity_field_entity_view($entity, $type, $view_mode, $langcode) {
  if ($plugin = context_get_plugin('condition', 'entity_field')) {
    $plugin->execute($type, $entity);
  }

  if ($plugin = context_get_plugin('condition', 'entity_view_mode')) {
    $plugin->execute($type, $view_mode);
  }
}

Increasing priority to major and recommending that a new tag is created.

patch #37 ?

Sorry, #9,