Choose language(done) should be Choose language (done) for example.

Files: 
CommentFileSizeAuthor
#6 space-inside-span-2022233-6.patch603 bytesStephaneQ
PASSED: [[SimpleTest]]: [MySQL] 56,468 pass(es).
[ View ]
#1 fix-missing-spaces-2022233-1.patch603 bytesStephaneQ
PASSED: [[SimpleTest]]: [MySQL] 58,171 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new603 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,171 pass(es).
[ View ]

Here is my first patch, hope I did it correctly

hmm, maybe the space should go inside the "visually-hidden" span rather than before it, what do you think?

Inside or outside the span, browsers render it the same way, so I thought it was cleaner to put it outside.

Tell me if I'm wrong, I'll resend the patch.

Status:Needs review» Reviewed & tested by the community

I think this is okay.

#3 it renders differently if the span is hidden with CSS

StatusFileSize
new603 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,468 pass(es).
[ View ]

Ok, so let's put it inside the span

#6 looks good to me.

Status:Reviewed & tested by the community» Fixed

Committed 972bdf1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.