Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vitalblue’s picture

hi to all I'm planning to work on basic functionality of Drupal7 version and then think about the rest

thanks

Northern_Girl’s picture

Ready to make tests! :)

vitalblue’s picture

first patch restore most of basic functionality

Brentnauer’s picture

Will this support OG?

vitalblue’s picture

it is planned to support OG in the future too.
For the moment I'm working on basic functionality and the rest will follow

Anjaro’s picture

Hi, sounds good that there is being worked on this.

Im just a bit confused on how to proceed.
Do i install the old alpha or the dev and make the changes with the above patch ?
Or is it included in the dev ?

Thanks for any answer.

vitalblue’s picture

hi Anjaro, still I don't have an answer for this patch.
I send a msg to disterics, owner of this module but I got no reply, for the moment.

I will let you know when this will be available in a new version.

vitalblue’s picture

Status: Active » Needs review
vitalblue’s picture

Priority: Minor » Normal
micahw156’s picture

@vitalblue - FYI, I just submitted a patch on #2103119: Configuration of Shoutbox not possible in D7 before I saw your patch from #3 above. Looks like the last patch committed on 7.x-1.x branch was over two years ago. Any word back yet from the maintainer?

I'll review your patch if I get a chance, but I'm in the middle of a big project right now and only had time to throw out a quick one-line fix for the config issue.

vitalblue’s picture

Hi micahw156, thanks for your response.
I didn't have any news from maintainer yet and still waiting for my patch.

I check the issue that you mentioned.
I have already change the path to admin/config/user-interface/shoutbox, but I don't have any problem to put that in "content" instead of "user-interface" level.

For the moment my aim is to resolve the maintenance problem of the module and then more patches will come.
Thanks

micahw156’s picture

@vitalblue - I've uploaded a new patch to #2103119: Configuration of Shoutbox not possible in D7 using admin/config/user-interface/shoutbox instead.

happyhurricane’s picture

Worked with micahw156 to perform a coder review with the patch from #3 applied. Attaching new patch and interdiff for comparison.

happyhurricane’s picture

Related issues:
FileSize
77.1 KB

Uploading correct patch file. Sorry.

micahw156’s picture

Related issues:
FileSize
74.88 KB
2.68 KB

Removed "info added by drupal.org packaging script" from .info files. This was added by the first patch, and should not be part of the git repository.

To be clear, the interdiff shows the changes between #14 and #15. The -15 patch is a diff against 7.x-1.x-dev (commit baee183).

We've put this work in a sandbox as the issue2023731 branch at https://bitbucket.org/hfccwebdev/module_shoutbox

(Also, fwiw, the bad upload patch on #13 was my fault.)

micahw156’s picture

Related issues:
FileSize
14.99 KB
89.88 KB

Removed LICENSE.txt file as mentioned in #1469876: Remove LICENSE.txt from Git repository.

micahw156’s picture

@vitalblue: Also to clarify, there are no functional code changes between your -1 patch and the latest -16 patch. I haven't even looked at your code changes or enabled the module on a site yet. All we did today was run through coder module and clean up white spaces and comments as indicated by coder.

If you apply our changes and compare to your version using git diff -b you'll see exactly what we did here.

We will try to look at the code itself some time next week. Again, not really looking for a co-maintainer role, just trying to help get this patch commit ready.

@Anjaro: if you want to test with these patches, your best solution is to install git, then follow the instructions on the module's Version control page to clone the 7.x-1.x branch to your environment. Then download the latest patch and apply it using git apply.

Alternatively, you can use git to clone the sandbox I've created at https://bitbucket.org/hfccwebdev/module_shoutbox and check out the issue2023731 branch. I will continue to commit patches to that sandbox at least as long as I stay involved with this issue. If you really don't want to deal with git, you can test by downloading packages from the Downloads/Branches page on the Bitbucket repository.

Anjaro’s picture

Thanks
Sadly i dont have git, im on a hosted server and as i understand it, you have to have access to your own server to play with git ?
I will give a go on https://bitbucket.org/hfccwebdev/module_shoutbox/downloads
If no luck with this, im patience :) and i will hang on and wait to download the next version when available.
Thanks for your effort.

micahw156’s picture

Marked #1798870: Getting together for a new version as duplicate of this issue.

micahw156’s picture

@Anjaro,

You can install git locally. There are versions for Windows, Mac OS X and Linux. You can then use git to check out repositories, apply patches, etc, in your local environment, then transfer those files to your hosted server using normal means. However, if the downloads from bitbucket work for you, that's probably the easiest.

I highly, highly, highly recommend using git to manage revisions of the local copy of the files you're uploading to your host. If you've ever made a backup copy of a file before changing it, git is for you. Play with it for a couple of hours and you'll wonder how you ever lived without it.

micahw156’s picture

Marked #1601150: Is this project still alive? as a duplicate of this issue.

Leeteq’s picture

@vitalblue; have you tried to follow this procedure, in case you want (co-)maintainership over this module?

"Dealing with unsupported (abandoned) projects"
https://drupal.org/node/251466

vitalblue’s picture

Hi Leeteq,
the ownership of this module passed to me few days ago.
I'm working now to release my first version this weekend.

Thanks for your help

Anjaro’s picture

YES glad to hear that, Vitablue.

vitalblue’s picture

Status: Needs review » Closed (fixed)

patch applied

thanks a lot