Updated: Comment #0

Problem/Motivation

Altering the menu list is messy.
See #2004428: Less ugly operations altering.

Also, this is probably already intended to be done as part of converting to configuration and entities.

See:
$form_id 'filter_admin_overview'
admin/config/content/formats/

Proposed resolution

Use EntityListController for formats

Remaining tasks

User interface changes

No.

API changes

?

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +D8MI, +language-config

Indeed, looks like from filter.admin.inc, neither the list nor the format editing is handled with entity controllers. Surprising! Looks from the code only filter_admin_overview() and filter_admin_overview_submit() are involved in the list, so this should be a relatively easy change.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

BTW I looked at #1781372: Add an API for listing (configuration) entities and related issues whether there was already an issue for this, but could not find one.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Closed (duplicate)

This is covered by #1987124: Convert filter_admin_format_page() and filter_admin_overview() to a Controller already.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

I *knew* there should be an issue for that, thanks!