Not sure the base reason, but it doesn't sound right to create an translation_entity_access_check instead of entity_translation_access_check.

Files: 
CommentFileSizeAuthor
#36 2024867-rename-translation_entity-36.patch173.94 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 58,285 pass(es).
[ View ]
#33 2024867-rename-translation_entity-33.patch167.61 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2024867-rename-translation_entity-33.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#31 2024867-rename-translation_entity-31.patch173.54 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#31 2024867-diff-28-31.txt980 bytesvijaycs85
#28 2024867-rename-translation_entity-28.patch172.58 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 56,807 pass(es).
[ View ]
#28 2024867-diff-15-28.txt16.64 KBvijaycs85
#15 2024867-rename-translation_entity-15.patch171.11 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 58,095 pass(es).
[ View ]
#15 2024867-diff-11-15.txt6.49 KBvijaycs85
#12 rename-content-translation-test.png19.97 KBvijaycs85
#11 2024867-rename-translation_entity-11.patch169.11 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 58,035 pass(es).
[ View ]
#11 2024867-diff-7-11.txt29.63 KBvijaycs85
#7 2024867-rename-translation_entity-7.patch156.48 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 58,085 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#4 2024867-rename-translation_entity-4.patch146.24 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 58,094 pass(es).
[ View ]
#1 2024867-rename-translation_entity-1.patch139.55 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed during invocation of run-tests.sh.
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new139.55 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed during invocation of run-tests.sh.
[ View ]

Initial patch...

Status:Needs review» Needs work

The last submitted patch, 2024867-rename-translation_entity-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new146.24 KB
PASSED: [[SimpleTest]]: [MySQL] 58,094 pass(es).
[ View ]

Renaming files.

Issue tags:+D8MI, +language-content

Thanks for working on this but I think we should avoid the entity_translation namespace, since it would prevent us from being able to provide a proper upgrade path from D7 ET to D8 in contrib. What about content_translation instead? It would be consistent with config_translation.

StatusFileSize
new156.48 KB
FAILED: [[SimpleTest]]: [MySQL] 58,085 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

yep, content_translation makes more sense...

Title:Rename translation_entity to entity_translationRename translation_entity to content_translation

Status:Needs review» Needs work
Issue tags:-D8MI, -language-content

The last submitted patch, 2024867-rename-translation_entity-7.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+D8MI, +language-content

StatusFileSize
new29.63 KB
new169.11 KB
PASSED: [[SimpleTest]]: [MySQL] 58,035 pass(es).
[ View ]

Updating labels and seems missed to remove few files...

StatusFileSize
new19.97 KB

BTW, tests are green locally!

rename-content-translation-test.png

Status:Needs review» Needs work
Issue tags:+sprint

Awesome! Just some minor stuff and we should be good to go :)

+++ b/core/modules/content_translation/content_translation.admin.inc
diff --git a/core/modules/translation_entity/translation_entity.admin.js b/core/modules/content_translation/content_translation.admin.js
rename from core/modules/translation_entity/translation_entity.admin.js
rename to core/modules/content_translation/content_translation.admin.js

We need to update the behavior namespace here.

+++ b/core/modules/content_translation/content_translation.install
@@ -2,7 +2,7 @@
+ * Installation functions for content translation module.

I'd say it was missing an article but I'd keep the uppercase letters:

Installation functions for the Content Translation module.

+++ b/core/modules/content_translation/content_translation.module
@@ -14,12 +14,12 @@
+      $output .= '<p>' . t('The Content Translation module allows you to create and manage translations for your Drupal site content. You can specify which elements need to be translated at the content-type level for content items and comments, at the vocabulary level for taxonomy terms, and at the site level for user accounts. Other modules may provide additional elements that can be translated. For more information, see the online handbook entry for <a href="!url">Content Translation</a>.', array('!url' => 'http://drupal.org/documentation/modules/entity_translation')) . '</p>';

The correct url currently is https://drupal.org/documentation/modules/translation_entity. It will change again probably.

+++ b/core/modules/content_translation/content_translation.module
@@ -515,15 +515,15 @@ function translation_entity_controller($entity_type) {
+ * Checks whether an content translation is accessible.

a content translation

Component:entity system» translation_entity.module

We'll need to rename the component too. Gabor, will you? ;)

Status:Needs work» Needs review
StatusFileSize
new6.49 KB
new171.11 KB
PASSED: [[SimpleTest]]: [MySQL] 58,095 pass(es).
[ View ]

Thanks for the review @plach. Here is my update:

For #13:

  1. Behaviour change in js - Fixed
  2. Installation comment - Fixed
  3. Link update - Updated and created #2026089: Change the documentation page link in content_translation module for future update
  4. a content translation - Fixed

Status:Needs review» Needs work
Issue tags:-D8MI, -sprint, -language-content

The last submitted patch, 2024867-rename-translation_entity-15.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 2024867-rename-translation_entity-15.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 2024867-rename-translation_entity-15.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+D8MI, +sprint, +language-content

FYI - Seems locally all these failing test cases are fine :)

Status:Needs review» Reviewed & tested by the community

QED :)

Category:bug» task

This is not a bug at all.

The main reason for renaming ET is #1985488: Consider renaming translation_entity module, which is actually a bug.
However I agree this is a task :)

If we want to have this land first, then it should have Avoid commit conflicts.

Status:Reviewed & tested by the community» Needs work

@alexpott points out there are unrelated changes in the patch that are not involved with the rename. Eg. phpdoc type documentation changes. Those should not be coupled in, making it easier to review and get committed.

Status:Needs work» Needs review
StatusFileSize
new16.64 KB
new172.58 KB
PASSED: [[SimpleTest]]: [MySQL] 56,807 pass(es).
[ View ]

Removing changes that are not related to this issue.

Status:Needs review» Reviewed & tested by the community

Let's get this in then! Thanks for rolling it this way :)

Status:Reviewed & tested by the community» Needs work

From MenuFormController::actions()

    // We cannot leverage the regular submit handler definition because we have
    // button-specific ones here. Hence we need to explicitly set it for the
    // submit action, otherwise it would be ignored.
    if ($this->moduleHandler->moduleExists('translation_entity')) {
      array_unshift($actions['submit']['#submit'], 'translation_entity_language_configuration_element_submit');
    }

Need to update...

Status:Needs work» Needs review
StatusFileSize
new980 bytes
new173.54 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Not sure how did I miss it....

Status:Needs review» Needs work

Status:Needs work» Needs review
StatusFileSize
new167.61 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2024867-rename-translation_entity-33.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Re-rolling...

How did this become 5k smaller vs. the prior patch?

Status:Needs review» Needs work

The last submitted patch, 2024867-rename-translation_entity-33.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new173.94 KB
PASSED: [[SimpleTest]]: [MySQL] 58,285 pass(es).
[ View ]

somehow, can't re-roll after that patch.. had to re-do all again. hope this is the closer one, but needs full review again :(

Status:Needs review» Reviewed & tested by the community

I spot-checked and it looked good. Should be up for @alexpott again if/when green :)

Status:Reviewed & tested by the community» Fixed

Committed de3558c and pushed to 8.x. Thanks!

Removing tag

Component:translation_entity.module» ajax system

This was also added to the "original" change notice for the introduction of the module (introduction happened in November 2012, I just wrote the change notice). See https://drupal.org/node/2028009

Component:ajax system» content_translation.module

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags:-sprint

Remove from sprint!