Entity translation support [#2025913]

This is a great module, it is very nicely written. I am currently doing a multilingual site using entity translated nodes and ran into some issues with getting advanced polls to translate. In looking at the code some support was there for translations but it seemed a bit off so I am not sure that entity translation support is actually a supported feature - which is why I am opening this as a feature request.

I have a patch which seems to work, although I think it could use some work - specifically in the advpoll_get_data function where it tries to look for language fields and falls back to 'und'. I added some code specifically to handle the 'choices' field because this is really the only one that needs to be translatable, but there is nothing to prevent users from making a mistake and setting other fields to translatable.

The nice thing about entity translation is that the poll results are aggregated across both languages automatically since it is a single node. One other fairly major change I needed to make was to index the choices with choice_id and not the text so that the comparisons in advpoll_voteapi.inc are language agnostic.

Comment	File	Size	Author
#9	advpoll-entity_translation-2025913-9.patch	5.38 KB	Offlein
#9
#3	advpoll_entity-translation-2025913-3.patch	5.19 KB	spotzero
#3
#2	advpoll_entity-translation-2025913-2.patch	5.23 KB	joel_osc
#2
#1	advpoll_entity-translation-2025913-1.patch	5.23 KB	joel_osc
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

joel_osc CreditAttribution: joel_osc commented 22 June 2013 at 18:38

File	Size
advpoll_entity-translation-2025913-1.patch	5.23 KB

Hope the community can help clean this patch up...this is a great module - it would be awesome to have fully entity translation support.

Comment #2

joel_osc CreditAttribution: joel_osc commented 22 August 2013 at 14:35

Status:

Active

» Needs review

File	Size
advpoll_entity-translation-2025913-2.patch	5.23 KB

Slight change to make the results show up properly translated.

Comment #3

spotzero CreditAttribution: spotzero commented 2 October 2013 at 20:31

File	Size
advpoll_entity-translation-2025913-3.patch	5.19 KB

The provided patch in #2 did not apply cleanly to the 7.x-3.x branch.

I've fixed the problems, and the attached patch applies for me.

Comment #4

airstarh CreditAttribution: airstarh commented 16 October 2013 at 06:42

Thank you very much! It helps me!
Actually
advpoll_entity-translation-2025913-2.patch - helped. But stop working after D7 core update or Entity Translation update.
Then I googled again and saw
advpoll_entity-translation-2025913-3.patch
It helped again.
Could you know if it would work after the next D7 or ET update?
Thanks anyway!

Comment #5

Echofive CreditAttribution: Echofive commented 15 November 2013 at 09:27

Hi,

The patch "advpoll_entity-translation-2025913-3.patch" won't work for me.
When I apply it, I get some errors when I try to edit an existing node or its translation.

Comment #6

joel_osc CreditAttribution: joel_osc commented 26 November 2013 at 00:26

Can you post the errors? I have it working on a production site, so I assume the errors won't be too hard to fix.

Comment #7

Offlein CreditAttribution: Offlein commented 22 January 2015 at 18:50

Issue summary:

View changes

This seems to be working perfectly on our site.

Comment #8

Offlein CreditAttribution: Offlein commented 24 February 2015 at 00:14

Status:

Needs review

» Needs work

Actually, no, I take that back. This made it so unlimited voting stopped working and so I couldn't produce any new Advanced Polls without getting an error about including 2 options and about how one choice is required. I'll look into what could be causing this...

Comment #9

Offlein CreditAttribution: Offlein commented 24 February 2015 at 17:40

Status:

Needs work

» Needs review

File	Size
advpoll-entity_translation-2025913-9.patch	5.38 KB

OK, the previous patch worked just fine when editing existing nodes, but would fail on new ones because (for reasons not 100% clear to me) new node forms all produce undefined language elements that have the language applied later. The thing was attempting to validate 'en' fields as 'en', when the arrays hadn't been changed from 'und' yet.

For what it's worth, I don't actually know if I think this is the right way to handle validation of this. It seems like you're supposed to write an entity translation validation handler. But... On the other hand, I also don't see why this is "wrong", so I can't speak to that.

Here's the new patch which should work for new and existing nodes.