Hi,

Recently noticed that variable filter_allowed_protocols meets twice in code, but with different default values (see drupal_strip_dangerous_protocols() and _filter_url()). In the second function missing tel protocol.

I think that this protocol should be supported. Moreover, sequence of tags in default value should be the same. So I attached a patch that solves this issue.

Files: 
CommentFileSizeAuthor
drupal-different-default-values-for-filter_allowed_protocols-variable.patch835 bytesSpleshka
PASSED: [[SimpleTest]]: [MySQL] 40,387 pass(es).
[ View ]

Comments

Status:Needs review» Needs work

Status:Needs work» Needs review

Thanks @Spleshka, the patch looks fine.
The fix is small and accurate, I think we can proceed with this code clearance.

Does it look like RTBC ? :)

Status:Needs review» Reviewed & tested by the community

Yep, updating status.

Any updates here? Patch seems to be obvious.

Still no progress?

+1 to commit

Status:Reviewed & tested by the community» Fixed
Issue tags:+7.23 release notes

Thanks; this looks like the previously un-filed followup to #945332: Allow "tel:" protocol through drupal_strip_dangerous_protocols.

Drupal 8 actually lost support for 'tel' entirely so we should have an issue for that, but I suppose that doesn't stop fixing the inconsistency in Drupal 7.

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/705eb17

Automatically closed -- issue fixed for 2 weeks with no activity.