Hi guys,

I check the module carefully and it seems to be very useful.
However, I was unable to find a proper Drupal 7 version so far.

I checked the 7.x-1.x branch, but it doesn't seem to work.... it seems to be a simple copy of the Drupal 6 branch

CommentFileSizeAuthor
lazy_image_loader-Port_module_to_Drupal_7.patch17.24 KBxiukun.zhou
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xiukun.zhou’s picture

xiukun.zhou CreditAttribution: xiukun.zhou commented
Issue summary: View changes

then in #1 update and add the patch

sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented

Thanks but are you sure? people are using 7.x-1.0-beta1, have you tried it?

xiukun.zhou’s picture

xiukun.zhou CreditAttribution: xiukun.zhou commented

7.x-1.0-beta1 = 7.x-1.x-dev, Unable work to me, code is still very old(drupal 6). my drupal is 7.23-dev

the code in lazy_image_loader-7.x-1.0-beta1, see drupal_add_js():

drupal_add_js($path . '/jquery.lazyload.js', 'module', 'header', TRUE);
drupal_add_js($path . '/lazy_image_loader.js', 'module', 'heade, TRUE);
sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented
Status: Needs review » Needs work

I'll consider your patch, i see that it includes some coding standards as well. tx
The patch need a bit of a cleanup : "No newline at end of file" , there are some empty lines as well

xiukun.zhou’s picture

xiukun.zhou CreditAttribution: xiukun.zhou commented

OK, thanks sinasalek.
lazy_image_loader/lazy_image_loader.info
core = 6.x

to

core = 7.x

and add hook_library();

_lazy_image_loader_page_match() function rebuild form block configure page

xiukun.zhou’s picture

xiukun.zhou CreditAttribution: xiukun.zhou commented
Issue summary: View changes

Update

Dandily’s picture

Dandily CreditAttribution: Dandily commented
Issue summary: View changes

I apply this patch and everything is looking ok, but just looking. With using HTTPFox for Firefox i can see, that all images are loading on the page opening and after scroll they just showing with selected in settings effect.

I cant see no errors anywhere, what can it be?

Its the best module, because you dont need to change images, module can take any.

sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented

The patch will be committed if someone other the write make it RTBC