Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Follow up of #2004710: Add tests for block, menu, vocabulary and views listings.
Proposed resolution
Add tests.
Remaining tasks
Tests for:
- custom blocks listings
- contact forms listings
- formats listings
- shortcut listings
- maintenance settings page
- site information settings page
- account settings page
- role settings page
User interface changes
No.
API changes
No.
Related
#2019831: people and roles page broken
#2027577: Missing translate operation for maintenance settings page
Comments
Comment #1
Gábor HojtsyYay! Did you forgot to post the patch? :)
Comment #2
kfritscheAttached tests for
Because of #2019831: people and roles page broken and #2027577: Missing translate operation for maintenance settings page some tests should fail.
Comment #3
kfritscheYou added tags, just while I was uploading the patch, which removed them.
Adding again.
Comment #4
YesCT CreditAttribution: YesCT commentedalphabetical is nice.
Role is like the other entities, not a translate tab, but is a listing so needs a test role and then a do like the others.
Comment #6
kfritschePermissions and modules are now alphabetical orderer.
Also the roles test is fixed now and works like the others.
I attached also a merged patch which includes #2019831: people and roles page broken latest patch (#6), which should go green.
Comment #7
kfritscheAnd needs review... (I will never learn.)
Comment #9
kfritscheForgot to rebase so the patch removed changes from #2027577: Missing translate operation for maintenance settings page and thats caused it to fail.
Comment #10
YesCT CreditAttribution: YesCT commentedthis comment should say
// Get the contact form listing.
this is testing a generic (given) settings page, not always the maintenance settings page.
Change to:
// Get the settings page.
We might also want to add info that the translate link is usually in a tab on the page?
Comment #11
David Hernández CreditAttribution: David Hernández commentedAttached patch without fix for showing the test broken and patch with fixes mentioned by YesCT.
Comment #12
David Hernández CreditAttribution: David Hernández commentedchanged status
Comment #13
YesCT CreditAttribution: YesCT commentedlooks great!
Comment #14
Gábor HojtsyCommitted, yay! Hiperyay! The commit message used was:
Issue #2027587 by kfritsche, David Hernández, dawehner, YesCT: Add tests for custom blocks, contact forms, formats, shortcut listings and settings pages.; fix for user roles from #2019831 included, otherwise tests would not pass; yay
Comment #15
YesCT CreditAttribution: YesCT commentednovice followup
#2028067: Clean up the added tests, by not calling procedural wrapper and fixing grammar
Comment #16
kfritscheSomehow only the patch from #2019831: people and roles page broken got in the test still needs to be get in.
Rerolled patch with only the patch from here without #2019831: people and roles page broken as its already in.
Comment #17
Gábor HojtsySorry, thanks!