All of our test classes are named in the format SomethingTest, It seems we have a test class called ModuleEnable, which should be renamed to ModuleEnableTest. Enough said.

CommentFileSizeAuthor
#2 2029375-2.patch1.21 KBdamiankloip
#2 interdiff-2029375-2.txt541 bytesdamiankloip
d8.ModuleEnableTest.patch1.21 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
+++ b/core/modules/system/lib/Drupal/system/Tests/Module/ModuleEnableTest.phpundefined
@@ -2,7 +2,7 @@
+ * Contains Drupal\system\Tests\Module\ModuleEnableTest.

Well, then it should have a starting "\" as well.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
interdiff-2029375-2.txt541 bytes
2029375-2.patch1.21 KB

You got me.

Status: Needs review » Needs work

The last submitted patch, 2029375-2.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review

#2: 2029375-2.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

+1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 4e1c0fe and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.