Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Simple enough, at the moment we are using a bastardised get() method to return the executable object. Let's atleast have a method to deal with this.
Comment | File | Size | Author |
---|---|---|---|
#12 | vdc-2029733-12.patch | 38.72 KB | tim.plunkett |
#7 | 2029733-7.patch | 39.09 KB | damiankloip |
#7 | interdiff-2029733-7.txt | 707 bytes | damiankloip |
#5 | 2029733-5.patch | 38.4 KB | damiankloip |
#2 | 2029733-2.patch | 38.38 KB | damiankloip |
Comments
Comment #1
dawehnerThis should @return a ViewExecutable if possible.
Comment #2
damiankloip CreditAttribution: damiankloip commentedLet's do that.
Comment #3
amateescu CreditAttribution: amateescu commentedLooks good to me :)
Comment #4
dawehner+1 this is a improvement.
Comment #5
damiankloip CreditAttribution: damiankloip commentedPure git reroll.
Comment #7
damiankloip CreditAttribution: damiankloip commentedThere was one conversion missing in ViewListController
Comment #8
dawehnerBack to RTBC
Comment #9
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #10
damiankloip CreditAttribution: damiankloip commented#7: 2029733-7.patch queued for re-testing.
Comment #11
alexpottNeeds a reroll...
Comment #12
tim.plunkettConflicted with #2032031: [Change notice] Deprecate use of views_get_view function in favour of Views::getView() method.
No actual changes, so marking back to RTBC.
Comment #13
alexpottCommitted 91fbd4b and pushed to 8.x. Thanks!