Updated: Comment #2
Problem/Motivation
The table that lists translatable strings on admin/config/regional/translate gets this CSS rule from the system.theme.css file:
tr.odd .form-item, tr.even .form-item {
white-space: nowrap;
}
It makes that the first column gets as wide as the sentences in it, and the second column gets very small and often out from the screen. It can be seen here:
(Or: admin/config/regional/translate?page=1 and especially on admin/config/regional/translate?page=2)
In the issue #1663130: Clean up css in Locale the white-space has been set as normal to avoid this:
.locale-translate-edit-form .form-item {
white-space: normal;
}
It seems that the selector is not specific enough and the rule doesn't apply (anymore).
Proposed resolution
I propose to specify the selector so that it overrides the system.theme.css rule:
.locale-translate-edit-form tr .form-item {
white-space: normal;
}
Remaining tasks
Create the patch with the CSS modification.
User interface changes
The width of the first column on the interface translation table is not affected by the length of the text inside it.
API changes
Nothing.
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#4 | beforepatch-tonarrow.png | 207.47 KB | YesCT |
#4 | afterpatchgood.png | 220 KB | YesCT |
#1 | translation-table-css-2030123-1.patch | 429 bytes | Outi |
translation-white-space.jpg | 72.76 KB | Outi |
Comments
Comment #1
Outi CreditAttribution: Outi commentedChanges the selector from
.locale-translate-edit-form .form-item
to.locale-translate-edit-form tr .form-item
Comment #2
Outi CreditAttribution: Outi commentedComment #2.0
Outi CreditAttribution: Outi commentedUpdated issue summary.
Comment #3
YesCT CreditAttribution: YesCT commentedI verified that the problem exists without this patch by:
installing in spanish
then going to the configuration section, languages, and user interface translation,
yes, the second page there shows the problem very well.
I tried out the patch,
and it fixes it. :)
------
coding style looks ok.
------
Is there any other page that might have been making use of the selector the way it was before that we should check is still ok?
The selector looks pretty specific to this page to me. So I think this is ok.
Comment #4
YesCT CreditAttribution: YesCT commentedoops.
Comment #5
Outi CreditAttribution: Outi commentedComment #6
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #7
alexpottCommitted 0fbf36c and pushed to 8.x. Thanks!
Comment #8.0
(not verified) CreditAttribution: commentedRemoved a help line from the summary template.