PHP notice when creating new Drupal user [#2030551]

The following notice pops up when I try to create a new user:

Notice: Undefined index: user_picture in Drupal\Core\Entity\EntityFormController->submitEntityLanguage() (line 438 of core/lib/Drupal/Core/Entity/EntityFormController.php).

When doing this, I'm logged in as user 1.

When I look into the code I see the following statement:

$previous_langcode = $form[$field_name]['#language'];

I guess the index "user_picture" isn't present in the array $form. Should we introduce an isset() to check if the index is present in the array?

Comment	File	Size	Author
#6	issue-2030551-6.patch	3.51 KB	marcingy
#6
#4	issue-2030551-4.patch	3.6 KB	marcingy
#4
#3	issue-2030551-3.patch	3.21 KB	marcingy
#3
#2	issue-2030551-2.patch	2.04 KB	marcingy
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

marcingy CreditAttribution: marcingy commented 28 June 2013 at 16:03

Assigned:

Unassigned

» marcingy

This only happens when we use the standard install and infact we get another notice when on php 5.4 which I will create another issue for.

Comment #2

marcingy CreditAttribution: marcingy commented 28 June 2013 at 16:50

Status:

Active

» Needs review

File	Size
issue-2030551-2.patch	2.04 KB

Test added to find the notice. This will fail.

Comment #3

marcingy CreditAttribution: marcingy commented 28 June 2013 at 17:15

File	Size
issue-2030551-3.patch	3.21 KB

And now the patch

Comment #4

marcingy CreditAttribution: marcingy commented 28 June 2013 at 17:17

File	Size
issue-2030551-4.patch	3.6 KB

Meh must save before creating patch

Comment #5

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 10 July 2013 at 11:39

Status:	Needs review	» Needs work
Issue tags:		+D8MI

Manually tested and the simpletest looks good.

Minor nit...

+++ b/core/modules/user/lib/Drupal/user/Tests/UserCreateTest.phpundefined
@@ -14,6 +14,15 @@
+  /**
+   * Modules to enable.
+   *
+   * Enable dummy module that implements hook_node_insert() for exceptions.
+   *
+   * @var array
+   */

The comment here doesn't look right...