Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.A boolean option in the UI should use a single checkbox, not a radio. (The exception is when the on/off state is not easily conveyed by a single statement you either check or don't.)
The options for whether to load retweets and replies would be much better represented as a checkbox for each one.
Furthermore, a negative should not be used.
So:
[] Load retweets
[] Load replies
Rather than:
Retweets:
() True
() FalseExclude replies:
() True
() False
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2030705.twitter_pull.box-radios-to-checkbox.patch | 1.28 KB | joachim |
Comments
Comment #1
joachim CreditAttribution: joachim commented> Furthermore, a negative should not be used.
Unfortunately, it's twitter API itself that's guilty of using a negative for its option. I'll leave this one to another issue, as we'd need to flip the value on submit to keep our internal configuration consistent with twitter.
Issue #2030705 by joachim: Fixed radios used for boolean options.
Comment #2
joachim CreditAttribution: joachim commentedBackported to 6.x-2.x.