Followup from #2015789-73: Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute, it is preferred to quote the attribute selector. This patch changes all instances of [dir=rtl] to [dir="rtl"]

Files: 
CommentFileSizeAuthor
#4 quote-rtl-attribute-2030925-4.patch77.81 KBechoz
PASSED: [[SimpleTest]]: [MySQL] 56,653 pass(es).
[ View ]
quote-rtl-attribute.patch78.63 KBechoz
PASSED: [[SimpleTest]]: [MySQL] 56,393 pass(es).
[ View ]

Comments

Status:Needs review» Reviewed & tested by the community

Looks great. Good hustle echoz.

Status:Reviewed & tested by the community» Needs work

Needs a reroll

git ac https://drupal.org/files/quote-rtl-attribute.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 80515  100 80515    0     0  16910      0  0:00:04  0:00:04 --:--:-- 17711
error: patch failed: core/themes/seven/install-page.css:50
error: core/themes/seven/install-page.css: patch does not apply

Status:Needs work» Needs review
StatusFileSize
new77.81 KB
PASSED: [[SimpleTest]]: [MySQL] 56,653 pass(es).
[ View ]

commit all the things! :-D

Status:Needs review» Reviewed & tested by the community
Issue tags:+Avoid commit conflicts

Looks ok.

Looks great, let's get this in before it becomes invalid. It touches too much code to continue to apply for too long.

#4: quote-rtl-attribute-2030925-4.patch queued for re-testing.

Issue tags:+RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

Status:Reviewed & tested by the community» Fixed
Issue tags:-Avoid commit conflicts

Committed b48f8fd and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.