When placing a block, the Place blocks button is displayed on the Configure block page.
Steps to reproduce:
- Navigate to admin/structure/block (Structure -> Blocks)
- Click on the Place blocks button
- Choose a block to place and click its Place block button
There is both a Place blocks button at the top of the page and a Save block button at the bottom of the page.
Clicking the Save block button operates as expected. Clicking the Place blocks button takes you back to the list of available blocks to choose a block to place. Usually only the second block is placed, but I had it place both blocks once.
Either this is a bug in that the button is there and shouldn't be, or it's a bug in that it's behavior does not allow one to place multiple blocks in a single run through. I'm guessing the former, but I might be wrong.
As an FYI, the Place blocks button does not show up if an already placed block is configured.
Comment | File | Size | Author |
---|---|---|---|
#3 | block-2031467-3.patch | 719 bytes | tim.plunkett |
place-blocks.png | 55.22 KB | oadaeh |
Comments
Comment #1
benjy CreditAttribution: benjy commentedComment #2
tim.plunkettThis is actually a menu system thing, not blocks. Also will likely be resolved by #2055853: [meta] Improve the place block UX; Separate interaction from the create block UX; Improve the existing blocks-by-theme layout
Comment #3
tim.plunkettI was mistaken! We're just missing a hook_menu entry for that route, so menu_get_item() is picking up the wrong one.
Comment #4
benjy CreditAttribution: benjy commented#2058321: Move the 'place block' UI into the block listing removes the place block page so postponing until that is resolved.
Comment #5
tim.plunkettSorry that text is wrong. It's the Configure block page. This is still a bug regardless of that issue.
Comment #6
benjy CreditAttribution: benjy commentedThis looks good. Don't think we need a test to check for the absence of a button on a page it should never have been on.
Comment #7
webchickHuh. No idea why this fixes it, but I can confirm it fixes it. Woohoo.
Committed and pushed to 8.x. Thanks!
Comment #8
tim.plunkettmenu_get_item() is still tied to menu_router, so when the local action code is trying to determine what page it was on, even while on admin/structure/block/add/bartik/some_block, it didn't have an entry, so it assumed it was on admin/structure/block. Now it knows what page its on.