The following steps end up in an error page:

1. Open admin/config/development/import
2. Choose a file that is not a *.tar file.
3. Hit upload.

The following error is thrown:

Exception: Invalid checksum for file "somefile.txt" : 24385 calculated, 262720 expected in Drupal\Component\Archiver\ArchiveTar->_error() (line 637 of /home/juampy/projects/drupal8/core/lib/Drupal/Component/Archiver/ArchiveTar.php).
The website has encountered an error. Please try again later.
CommentFileSizeAuthor
#4 interdiff.txt1014 bytesjuampynr
#4 drupal-config-import-upload-exception-2032711-4.patch3.28 KBjuampynr
#4 drupal-config-import-upload-exception-tests-will-fail-2032711-4.patch1.58 KBjuampynr
#1 drupal-config-import-upload-exception-tests-will-fail-2032711-1.patch1.63 KBjuampynr
#1 drupal-config-import-upload-exception-2032711-1.patch3.31 KBjuampynr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Active » Needs review
FileSize
drupal-config-import-upload-exception-2032711-1.patch3.31 KB
drupal-config-import-upload-exception-tests-will-fail-2032711-1.patch1.63 KB

Here is a patch that adds a test but fails and another one which catches the exception and sets an error in the form.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

nice! more of my sloppy being cleaned up.

perhaps we should unlink the file either way? otherwise, this looks ready.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

hmmm, ignore #2, we don't copy the file anywhere permanent, so no need to mess with the unlink. juampy++

juampynr’s picture

juampynr CreditAttribution: juampynr commented
FileSize
drupal-config-import-upload-exception-tests-will-fail-2032711-4.patch1.58 KB
drupal-config-import-upload-exception-2032711-4.patch3.28 KB
interdiff.txt1014 bytes

Reviewed the logic again. Unlinking the file even when there is an exception makes total sense. Thanks @beejeebus.

Status: Needs review » Needs work

The last submitted patch, drupal-config-import-upload-exception-tests-will-fail-2032711-4.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Reviewed & tested by the community

ok, this looks ready to go.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 7b3bf57 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.