These columns are defined by hook_schema but not in hook_views_data for node_field_revision:

  • langcode
  • default_langcode (I don't think this is necessary)
  • revision_timestamp
  • created
  • comment (I don't think this is necessary)
  • promote
  • sticky

Not sure if all this columns need to be stored in this table, things like created, comment, promote, sticky seem a little redundant?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pcambra’s picture

Status: Active » Needs review
FileSize
2.6 KB
pcambra’s picture

Added revision timestamp

dawehner’s picture

Issue tags: +Needs tests, +VDC

I guess we want to have some basic tests in order to know that it works in the future.
The actual missing fields (coming probably from the node_revision => node_field_revision page). look fine.

The question is whether we want to support a filter for the langcode if the language module is disabled (a basic string one).

Pancho’s picture

Priority: Normal » Major
Status: Needs review » Postponed
Issue tags: +revisit before beta

Doesn't block #1863906: [PP-1] Replace content revision table with a view, so I'm tentatively postponing this to the critical #1998366: [meta] SQLite is broken, which will soon introduce changes to the whole schema. Marking it major + tagging it, though.

Pancho’s picture

Issue summary: View changes

revision timestamp <> created

MustangGB’s picture

Issue summary: View changes
Status: Postponed » Needs work

Looks like any schema changes are done now.

catch’s picture

Issue tags: -revisit before beta

Not sure why this needs to be tied to the release schedule given it's not critical.

xjm’s picture

Issue tags: +beta target
dawehner’s picture

Status: Needs work » Fixed

We do have those now added automatically, yeah!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.