Follow up for #1641166: Undefined property: Drupal\Core\Language\Language::$locked in language_list()

Updated: Comment #0

Problem/Motivation

Docs are missing for properties.
https://drupal.org/node/1354#var

Proposed resolution

Add the docs.

Remaining tasks

User interface changes

No.

API changes

No.

Files: 
CommentFileSizeAuthor
#3 drupal8.language-system.2035007-3.patch1.59 KBspeely
PASSED: [[SimpleTest]]: [MySQL] 56,938 pass(es).
[ View ]
#1 drupal8.language-system.2035007-1.patch1.59 KBYesCT
PASSED: [[SimpleTest]]: [MySQL] 56,905 pass(es).
[ View ]

Comments

Assigned:YesCT» Unassigned
Status:Active» Needs review
StatusFileSize
new1.59 KB
PASSED: [[SimpleTest]]: [MySQL] 56,905 pass(es).
[ View ]

A first pass.

Needs review to see if the descriptions are actually accurate for what the properties are storing and why.

Looks good to me, but default could be clearer.

+++ b/core/lib/Drupal/Core/Language/Language.phpundefined
@@ -17,13 +17,64 @@
+   * Site default language, there is only one site default.

Proposal:

Flag indicating if this is the only site default language.

StatusFileSize
new1.59 KB
PASSED: [[SimpleTest]]: [MySQL] 56,938 pass(es).
[ View ]

Looks good to me, too - as well as penyaskito's proposal.

Attached is a patch which combines both proposals.

@speely interdiffs are really cool.

Want to try making one?

instructions on creating an interdiff, see https://drupal.org/documentation/git/interdiff | Microbranching workflow: http://xjm.drupalgardens.com/blog/interdiffs-how-make-them-and-why-they-...

Looks good to go

Issue summary:View changes
Status:Needs review» Reviewed & tested by the community

Good work!

still applies.

Component:language system» documentation

Changing component so I notice it next time I am doing Core commits.

Status:Reviewed & tested by the community» Fixed

Thanks all! Committed to 8.x.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.