When using in-place editing on an "article" node's "body" field in "teaser" view mode, the "form" in-place editor is used, which in turn uses CKEditor. When the text within CKEditor is modified, Edit.module's "Save" button should appear because changes have been made. But, it does not appear, because no formUpdated event is triggered.

CommentFileSizeAuthor
#1 2035083-1.patch729 bytesWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Needs review
FileSize
2035083-1.patch729 bytes

Super simple fix. Editor.module's JS API already had the necessary interface for it, it just wasn't using it yet!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Title: Text editors should trigger formUpdated event » Fix body in-place editing in teasers (text editors should trigger formUpdated event)
Category: task » bug
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

The patched code looks good. I tried the patch and it indeed made body editing work fine again on teaser view. Also elevating to major as per the bug explained in #2037687: Can no longer in-place edit body fields.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Yeah, I caught this one too, on node teasers. Confirmed that this fixes the problem, and since someone who's got a clue about about JS +1ed it, this one looks good to go, too.

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: -sprint

.

Automatically closed -- issue fixed for 2 weeks with no activity.