There is and bug, and future.

You can see bug, when you use field link in field_collection. Fields not highlighted when errors.
Also in hook_field_validate() not used array $errors, it is wrong.

CommentFileSizeAuthor
#1 validate-problem-2036115-1.patch4.97 KBSamvel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Samvel’s picture

Samvel CreditAttribution: Samvel commented
Status: Active » Needs review
FileSize
validate-problem-2036115-1.patch4.97 KB

Attached patch. Solved problem with form_set_error(). Now used $errors array.

Please review and implement my patch

jcfiala’s picture

jcfiala CreditAttribution: jcfiala commented
Issue summary: View changes
Status: Needs review » Fixed

Hey, you're right! I've merged this patch into dev. (Well, I mussed around with how the hook_field_widget_error() is being handled, but still.)

Thanks for the patch!

Samvel’s picture

Samvel CreditAttribution: Samvel commented

Good news.

Can you set me as autor of commit please?

jcfiala’s picture

jcfiala CreditAttribution: jcfiala commented

I don't know how to, but if you tell me, I can try. I go off of the process described at https://drupal.org/project/link/git-instructions to make sure I get things in correctly.

Samvel’s picture

Samvel CreditAttribution: Samvel commented

No problem, when you commit changes, append next option
--author="asik <asik@1596146.no-reply.drupal.org>"

Example:
git commit --author="asik <asik@1596146.no-reply.drupal.org>" -am "message"

Samvel’s picture

Samvel CreditAttribution: Samvel commented

jcfiala, as i see, it's already done. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.