Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Once #864006: Improve table semantics by adding scope or headers/id attributes is done the following two todos should be solved.
+++ b/core/modules/views/views.theme.incundefined
@@ -542,6 +542,7 @@ function template_preprocess_views_view_table(&$vars) {
+ // @todo Remove field_classes to field_attributes.
@@ -606,6 +607,7 @@ function template_preprocess_views_view_table(&$vars) {
+ // @todo Rename to header_attributes.
Comment | File | Size | Author |
---|---|---|---|
#11 | vdc-2036369-11.patch | 10.8 KB | bdone |
#8 | vdc-2036369-6.patch | 10.8 KB | bdone |
#8 | interdiff-6-3.txt | 1.27 KB | bdone |
#6 | vdc-2036369-6.patch | 10.8 KB | bdone |
#6 | interdiff-6-3.patch | 1.27 KB | bdone |
Comments
Comment #1
bdone CreditAttribution: bdone commentedcouldn't find these @todos in HEAD, but the task still seemed to need work
Comment #2
mgiffordIt's not in HEAD yet. Patch needs a re-roll.
Comment #3
bdone CreditAttribution: bdone commentedre-roll, since #864006: Improve table semantics by adding scope or headers/id attributes was committed
Comment #4
dawehnerAny reason to not include scope="col" into the attributes?
Comment #5
cam10025 CreditAttribution: cam10025 commentedFirst code review. I think it looks good. I tried to test fully. If I've erred in anyway, please inform me, so I can learn for future help :)
Comment #6
bdone CreditAttribution: bdone commentedre-rolled with @dawehner's suggestions in #4.
@cam10025: i'm not sure it should have been assigned to you, unless you planned on making it active and doing further work. please have a look at https://drupal.org/patch/review to make certain.
Comment #8
bdone CreditAttribution: bdone commentedrenamed interdiff to re-test
Comment #9
bdone CreditAttribution: bdone commentedComment #11
bdone CreditAttribution: bdone commentedrerolled against HEAD
Comment #12
dawehnerI am a bit confused about this issue vs. #1968398: Convert Views $row_classes to $row['attributes'] as both seem to do really similar things.
Comment #13
bdone CreditAttribution: bdone commentedyea, it does seem very similar. since that one is already RTBC, i'm guessing this should be marked as a duplicate.