Once #864006: Improve table semantics by adding scope or headers/id attributes is done the following two todos should be solved.

+++ b/core/modules/views/views.theme.incundefined
@@ -542,6 +542,7 @@ function template_preprocess_views_view_table(&$vars) {
+  // @todo Remove field_classes to field_attributes.

@@ -606,6 +607,7 @@ function template_preprocess_views_view_table(&$vars) {
+      // @todo Rename to header_attributes.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bdone’s picture

Status: Active » Needs review
FileSize
9.43 KB

couldn't find these @todos in HEAD, but the task still seemed to need work

mgifford’s picture

It's not in HEAD yet. Patch needs a re-roll.

bdone’s picture

dawehner’s picture

+++ b/core/modules/views/templates/views-view-table.html.twigundefined
@@ -52,7 +52,7 @@
-          <th{{ header_classes[key] }} scope="col">
+          <th{{ header_attributes[key] }} scope="col">

Any reason to not include scope="col" into the attributes?

cam10025’s picture

Assigned: Unassigned » cam10025
Status: Needs review » Reviewed & tested by the community

First code review. I think it looks good. I tried to test fully. If I've erred in anyway, please inform me, so I can learn for future help :)

bdone’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
1.27 KB
10.8 KB

re-rolled with @dawehner's suggestions in #4.

@cam10025: i'm not sure it should have been assigned to you, unless you planned on making it active and doing further work. please have a look at https://drupal.org/patch/review to make certain.

Status: Needs review » Needs work

The last submitted patch, interdiff-6-3.patch, failed testing.

bdone’s picture

Status: Needs work » Needs review
FileSize
1.27 KB
10.8 KB

renamed interdiff to re-test

bdone’s picture

Assigned: cam10025 » Unassigned

Status: Needs review » Needs work

The last submitted patch, vdc-2036369-6.patch, failed testing.

bdone’s picture

Status: Needs work » Needs review
FileSize
10.8 KB

rerolled against HEAD

dawehner’s picture

I am a bit confused about this issue vs. #1968398: Convert Views $row_classes to $row['attributes'] as both seem to do really similar things.

bdone’s picture

Status: Needs review » Closed (duplicate)

yea, it does seem very similar. since that one is already RTBC, i'm guessing this should be marked as a duplicate.