Follow-up for #1825896-42: Add module owner to plugin data on handlers

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -54,12 +54,14 @@ class Comment extends WizardPluginBase {
-      'field' => 'status'
+      'field' => 'status',
+      'provider' => 'user'
...
       'field' => 'status',
+      'provider' => 'user',

This change is wrong!

Files: 
CommentFileSizeAuthor
#4 fix-provider-keys-for-comment-wizard-2039677-4.patch774 byteslokapujya
PASSED: [[SimpleTest]]: [MySQL] 58,779 pass(es).
[ View ]
#2 followup-2039677-2.patch777 byteslokapujya
PASSED: [[SimpleTest]]: [MySQL] 58,378 pass(es).
[ View ]

Comments

Issue tags:+Novice

tagging

Assigned:Unassigned» lokapujya
Status:Active» Needs review
StatusFileSize
new777 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,378 pass(es).
[ View ]

I think we just want to change the provider to be 'comment'.

Title:Follow-up: Add module owner to plugin data on handlersFix 'provider' keys for comment wizard default filter definitions
Status:Needs review» Needs work

Changing the title, that is just not helpful, the fact that it's a followup should not be the main point :)

Patch is looking good, but:

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -55,13 +55,13 @@ class Comment extends WizardPluginBase {
     'status_node' => array(
...
+      'provider' => 'comment',

This filter handler is not provided by comment module but by node.

StatusFileSize
new774 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,779 pass(es).
[ View ]

Updated as said in #3.

Status:Needs work» Needs review

Status:Needs review» Reviewed & tested by the community

Looks good.

Status:Reviewed & tested by the community» Fixed

#2094839: Wizard should use the API like ViewExecutable::addItem to build the view is going to remove these protected properties in favour of using the API.

Committed b3b073e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.