Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cweagans’s picture

Status: Active » Needs review
FileSize
1.62 KB

Should this include RDF? If not, patch attached.

Status: Needs review » Needs work

The last submitted patch, 2042443_01-move-web-services-modules-to-separate-package.patch, failed testing.

cweagans’s picture

Status: Needs work » Needs review
FileSize
1.2 KB

Derp. I accidentally left some .htaccess bits for my environment in there.

Crell’s picture

Status: Needs review » Reviewed & tested by the community

I don't think RDF is a web service. It's closer to an SEO tool the way we use it. Web services colloquially mean non-HTML things, and RDF gets put into HTML.

cweagans’s picture

Cool :)

alexpott’s picture

Status: Reviewed & tested by the community » Needs review

So the only modules not in the "core" group that are in core are some multilingual modules. I think if we are going to do this then we need to have a think about ALL the modules in core.

Crell’s picture

Alex: Please provide better guidance on what "think about" means, or else based on historical evidence this issue will sit here untouched for the next year. (I've seen that happen a dozen times.)

As is, there's a clear UX benefit to this change on its own, and the precedent of separating things out in core has already been set.

amateescu’s picture

How about doing what Commerce does in D7, which advises contrib modules to use the "Commerce (contrib)" package? We could have "Multilingual (Core)", "Web services (Core)", "Fields (Core)", etc. Or, even better, we could/should do #1868444: Introduce tags[] in module.info.yml file to categorize modules by provided functionality. instead.

But I think this should be discussed in an issue with more than 5 followers (6 after I post this :P).

And a small patch review: since the package string now contains a space, it should be wrapped in quotes.

sphism’s picture

I'd suggest naming it the other way around: Core blah, Core foo, Commerce whatever - that way all core stuff is kept together alphabetically.

Crell’s picture

I'd be fine with #9.

sphism’s picture

I think this needs to be done for the whole of core, see #2064727: Separate Core modules into separate packages on module page

@Crell: I was thinking about having it as 'Core Web Services', Core Multilingual and so on, and i guess it depends where other non core web service modules go. Would contrib modules exist in the same web services package as the core ones, or in a separate package?

If contrib modules go into the same package then you just want to call it 'Web Services' (and hopefully flag some as being core in some way)

If contrib modules go in a different package then you end up with:
...
Core Web Services at the top of the list
...
...
...
Web Services at the bottom of the list
...

In which case I guess it's better to have:
...
Web Services
Web Services Core
...

I thought it was a quick simple decision, but it seems like it's not

amateescu’s picture

So you're going back to my #8, nice :)

cweagans’s picture

Status: Needs review » Needs work

Per #8:

since the package string now contains a space, it should be wrapped in quotes.

As for naming, I say just pick something and go with it. It's easy to change later, and it sounds like Alex wants to have a bigger discussion about categorization.

sphism’s picture

Status: Needs work » Needs review

@amateescu: Not necessarily. I think it just highlights that in different situations you may want it a different way. Which makes tagging a useful proposition.

-- moved comment to a general discussion thread #2064727: Separate Core modules into separate packages on module page

alansaviolobo’s picture

Issue summary: View changes
Status: Needs review » Closed (fixed)

changes seem to be already present in core.