We already customized the list of ignored names for annotations by adding @endlink, but we need @file too.

The full list of stock ignored names is in AnnotationReader::$globalIgnoredNames

This is major since it allows non-annotated classes in plugin directories.

CommentFileSizeAuthor
#2 annotation-2042545-2-FAIL.patch638 bytestim.plunkett
#2 annotation-2042545-2-PASS.patch1.36 KBtim.plunkett
annotation-file.patch751 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
Issue tags: +DX (Developer Experience), +Plugin system
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
annotation-2042545-2-PASS.patch1.36 KB
annotation-2042545-2-FAIL.patch638 bytes

Here's an example.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

I am wondering whether other tags like @defgroup @ingroup should be also added to potentially improve performance. Regardless of that, this is RTBC.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

ingroup is part of the defaults, see the link in the OP.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.