Remaining:

  1. system.schema.yml
    a. system.rss
  2. image.schema.yml
  3. picture mappings
  4. date formats
Files: 
CommentFileSizeAuthor
#34 image-styles.png194.84 KBYesCT
#33 2044387-config-translation-imagestyles-33.patch909 bytesYesCT
PASSED: [[SimpleTest]]: [MySQL] 457 pass(es).
[ View ]
#23 core-fixed.patch3.16 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 447 pass(es).
[ View ]
#21 interdiff.txt1.93 KBGábor Hojtsy
#21 2044387-config-translation-rss-image-20.patch7.86 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 435 pass(es).
[ View ]
#18 interdiff.txt1.23 KBGábor Hojtsy
#18 2044387-config-translation-rss-image-18.patch7.73 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] 436 pass(es), 0 fail(s), and 1 exception(s).
[ View ]
#16 interdiff.txt883 bytesGábor Hojtsy
#16 2044387-config-translation-rss-image-15.patch7.71 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] 439 pass(es), 0 fail(s), and 1 exception(s).
[ View ]
#13 2044387-config-translation-rss-image-13.patch7.64 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] 441 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
#13 interdiff.txt1.19 KBGábor Hojtsy
#11 2044387-config-translation-rss-image-11.patch7.53 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] 436 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
#11 interdiff.txt2.65 KBGábor Hojtsy
#9 2044387-config-translation-rss-image-9.patch6.7 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] 421 pass(es), 2 fail(s), and 1 exception(s).
[ View ]
#9 interdiff.txt2.11 KBGábor Hojtsy
#8 interdiff.txt909 bytesGábor Hojtsy
#8 2044387-config-translation-rss-image-7.patch5.75 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 424 pass(es).
[ View ]
#6 2044387-config-translation-rss-image-5.patch5.65 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] 426 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#4 2044387-config-translation-rss-image-4.patch5.44 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] 412 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#1 2044387-config-translation-rss-image-1.patch1.12 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 413 pass(es).
[ View ]
#1 config-translation-system.rss_.png40.8 KBvijaycs85
#1 config-translation-image.png135.76 KBvijaycs85

Comments

Title:Add remaining configuration entity/ page into configuration translation moduleAdd remaining configuration entity or page into configuration translation module
Status:Active» Needs review
StatusFileSize
new135.76 KB
new40.8 KB
new1.12 KB
PASSED: [[SimpleTest]]: [MySQL] 413 pass(es).
[ View ]

Initial patch with screenshot...

Issue tags:+Needs tests

Adding tag to extend test cases.

Assigned:Unassigned» Gábor Hojtsy
Issue tags:-Needs tests

Looking at this.

StatusFileSize
new5.44 KB
FAILED: [[SimpleTest]]: [MySQL] 412 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Adding tests. Also moved around mappers in alphabetical order. I can live with that in this patch :)

Status:Needs review» Needs work

The last submitted patch, 2044387-config-translation-rss-image-4.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Needs tests, +sprint
StatusFileSize
new5.65 KB
FAILED: [[SimpleTest]]: [MySQL] 426 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Found in #2044389: [META] Fix broken configuration translation pages that picture mapping also need to be supported. That is however blocked on another core issue I just found, see #2044865: Picture mappings cannot be edited. Added the picture mapper anyway here. No tests for that yet, since that would require #2044865: Picture mappings cannot be edited to land to pass.

Status:Needs review» Needs work

The last submitted patch, 2044387-config-translation-rss-image-5.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new5.75 KB
PASSED: [[SimpleTest]]: [MySQL] 424 pass(es).
[ View ]
new909 bytes

The image style related fail is due to #1809376: Use EntityListController for image styles, the current image style listing operations are not possible to alter. So we'll need to not try to test for what cannot be there for a while.

StatusFileSize
new2.11 KB
new6.7 KB
FAILED: [[SimpleTest]]: [MySQL] 421 pass(es), 2 fail(s), and 1 exception(s).
[ View ]

Add tests snippet for picture listing stuff.

Status:Needs review» Needs work

The last submitted patch, 2044387-config-translation-rss-image-9.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.65 KB
new7.53 KB
FAILED: [[SimpleTest]]: [MySQL] 436 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

The picture message assert was bad. Fixing that and adding date formats too :) This will fail as well due to #2038285: Update configuration schema for date formats as entities.

Status:Needs review» Needs work

The last submitted patch, 2044387-config-translation-rss-image-11.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.19 KB
new7.64 KB
FAILED: [[SimpleTest]]: [MySQL] 441 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

Make date format tests actually run. Uncomment failing test which we know is due to core issue. Add core issue link.

Status:Needs review» Needs work

The last submitted patch, 2044387-config-translation-rss-image-13.patch, failed testing.

So this uncovers that date format translate page does not work due to #2038285: Update configuration schema for date formats as entities, commenting that one out with todo as well.

Status:Needs work» Needs review
StatusFileSize
new7.71 KB
FAILED: [[SimpleTest]]: [MySQL] 439 pass(es), 0 fail(s), and 1 exception(s).
[ View ]
new883 bytes

Actual patch.

Status:Needs review» Needs work

The last submitted patch, 2044387-config-translation-rss-image-15.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new7.73 KB
FAILED: [[SimpleTest]]: [MySQL] 436 pass(es), 0 fail(s), and 1 exception(s).
[ View ]
new1.23 KB

There may be more failures around date stuff, let's comment this out for now.

Status:Needs review» Needs work

The last submitted patch, 2044387-config-translation-rss-image-18.patch, failed testing.

The notice was actually for the picture page which my core patch resolves, so I could not reproduce locally due to that patch applied. Reproduced now, commenting that out too.. Heh.

Status:Needs work» Needs review
StatusFileSize
new7.86 KB
PASSED: [[SimpleTest]]: [MySQL] 435 pass(es).
[ View ]
new1.93 KB

Status:Needs review» Fixed

Committed this for now. The @todo's will be taken care of later. They are clearly marked.

StatusFileSize
new3.16 KB
PASSED: [[SimpleTest]]: [MySQL] 447 pass(es).
[ View ]

Some core fixes landed in the meantime. Let's try to activate those tests :)

Status:Fixed» Needs review

Status:Needs review» Fixed

All right, committed and pushed that one.

Status:Fixed» Needs work

we still have this @todo for #1809376: Use EntityListController for image styles So lets keep this open for that.

$ ag -B3 -A3 1809376 *
lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.php
322-    $this->drupalGet('admin/config/media/image-styles');
323-
324-    $translate_link = 'admin/config/media/image-styles/manage/medium/translate';
325:    // @todo this will only be wired up once https://drupal.org/node/1809376 lands.
326-    // Test if the link to translate the style is on the page.
327-    //$this->assertLinkByHref($translate_link);
328-

[edited to correct the in code link]

That issue link is wrong, does anyone know where that is supposed to point?

#1809376: Use EntityListController for image styles is the right one as pointed out by @YesCT. The last number got lost for some reason in her quoted code. AFAIS the codebase has the right issue number/link too. So not sure how it got removed there...

Ahh, thanks. I should remember to actually *read* comments.... *slapsforehead*

Image style controllers landed, so let's close the loop here :)

Assigned:Gábor Hojtsy» YesCT

I'll do it. k?

Status:Needs work» Needs review
StatusFileSize
new909 bytes
PASSED: [[SimpleTest]]: [MySQL] 457 pass(es).
[ View ]

didn't test this locally.

StatusFileSize
new194.84 KB

without the patch link

[edit: oops without, I just forgot to turn on config translation. so the translate link is showing, lets just see how the tests come back. Should we look at something else?]

with:
image-styles.png

:)

Status:Needs review» Needs work

The last submitted patch, 2044387-config-translation-imagestyles-33.patch, failed testing.

Looks like a great patch! The fail is unrelated, but would ideally need to be fixed first, so we can ensure the module passes. Looks like the shortcut entity was renamed? Probably needs a quick new issue.

Status:Needs work» Needs review

Status:Needs review» Fixed

Yay, committed this patch then! Should be possible to close this down.

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Updated issue summary.