part of #2040105: [meta] Implement LocalTask plugins for previously converted routes

follow-up to #2004334: Separate Tabs (MENU_LOCAL_TASK) from hook_menu()

The login/new password/register tabs need to be converted to plugins.

Files: 
CommentFileSizeAuthor
#15 user_local_task-2044539-15.patch2.83 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,332 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#15 interdiff.txt1.35 KBdawehner
#13 user_tasks-2044539-13.patch1.48 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,301 pass(es), 5 fail(s), and 1 exception(s).
[ View ]
#10 user-2044539-10.patch4.11 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,002 pass(es), 16 fail(s), and 0 exception(s).
[ View ]
#4 2044539-4.patch7.23 KBpwolanin
PASSED: [[SimpleTest]]: [MySQL] 57,186 pass(es).
[ View ]
#4 2044539-3-4.increment.txt3.12 KBpwolanin
#3 2044539-3.patch4.11 KBpwolanin
FAILED: [[SimpleTest]]: [MySQL] 57,194 pass(es), 14 fail(s), and 2 exception(s).
[ View ]
#3 2044539-1-3.increment.txt1.19 KBpwolanin
#1 2044539-1.patch3.51 KBpwolanin
FAILED: [[SimpleTest]]: [MySQL] 57,099 pass(es), 15 fail(s), and 3 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new3.51 KB
FAILED: [[SimpleTest]]: [MySQL] 57,099 pass(es), 15 fail(s), and 3 exception(s).
[ View ]

simple conversion

Status:Needs review» Needs work

The last submitted patch, 2044539-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.19 KB
new4.11 KB
FAILED: [[SimpleTest]]: [MySQL] 57,194 pass(es), 14 fail(s), and 2 exception(s).
[ View ]

StatusFileSize
new3.12 KB
new7.23 KB
PASSED: [[SimpleTest]]: [MySQL] 57,186 pass(es).
[ View ]

This fixes the base plugin - we should have just have been pulling the path from the route patten, as we did earlier in the issue where that class was created, instead of trying to use the generator since the base plugin doesn't handle dynamic paths.

Issue tags:+MenuSystemRevamp, +WSCCI

tagging

I had the problem but it works now

+++ b/core/lib/Drupal/Core/Menu/LocalTaskBase.phpundefined
@@ -93,15 +93,9 @@ public function getTitle() {
+    // to generate the system path.
+    $route = $this->provider->getRouteByName($this->getRouteName());
+    return trim($route->getPath(), '/');

As written in IRC this is a step backwards, as we would have to use the generate method in the future again.

+++ b/core/modules/user/user.moduleundefined
@@ -814,25 +814,21 @@ function user_menu() {
-  // Other authentication methods may add pages below user/login/.
-  $items['user/login/default'] = array(

I guess we should not remove that feature?

@dawehner - it would still be possible to add sub-tabs below login, it just doesn't require this hack of an extra default local task.

StatusFileSize
new4.11 KB
FAILED: [[SimpleTest]]: [MySQL] 58,002 pass(es), 16 fail(s), and 0 exception(s).
[ View ]

Rerolled the patch without the changes in the local action manager.

Status:Needs review» Needs work

The last submitted patch, user-2044539-10.patch, failed testing.

This currently fails because the path with enabled language like /en/user/password. Given this path to menu_item_route_access() fails.
The proper solution for this problem is #2046737: Add a method to the AccessManager that only needs a route name and parameters

Status:Needs work» Needs review
StatusFileSize
new1.48 KB
FAILED: [[SimpleTest]]: [MySQL] 58,301 pass(es), 5 fail(s), and 1 exception(s).
[ View ]

Rerolled against recent yml discovery.

Status:Needs review» Needs work

The last submitted patch, user_tasks-2044539-13.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.35 KB
new2.83 KB
FAILED: [[SimpleTest]]: [MySQL] 58,332 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Fixed some of the failures.

Status:Needs review» Needs work

The last submitted patch, user_local_task-2044539-15.patch, failed testing.

Status:Needs work» Closed (duplicate)

This is all covered by #2102125: Big Local Task Conversion