leafo/lessphp precision issue needs documentation [#2044643]

For anyone else using this great module, you may run into a bug in leafo's lessphp code where span fluid widths are incorrectly calculated in responsive spans. There are many logged cases of this on the Github repo but there is a solution posted at https://github.com/Incenteev/lessphp/compare/recursion the solution has not been merged back into the main lessphp repo.

I am aware that this is not a bug of this module, but of the library it uses, but it almost made me have to go back to a desktop LESS compiler. Please feel free to close this with appropriate status.

Comments

Comment #1

corey.aufang CreditAttribution: corey.aufang commented 18 July 2013 at 22:27

If you want, you could try the patch in #2003628: Add ability to use node.js version of LESS.

If it works for you, it should allow files to be compiled by the standard less compiler and the issue with widths should be fixed.

I have not gone that far with testing myself.

Comment #2

basvredeling

Dutch

Amsterdam

CreditAttribution: basvredeling commented 25 July 2013 at 01:27

Thanks for the tips on https://github.com/Incenteev/lessphp
I've checked out the recursion branch and tried it as a temporary replacement of the generic lessphp library.
Seems to work well for now and my column width problems are solved fttb.

Comment #2.0

basvredeling

Dutch

Amsterdam

CreditAttribution: basvredeling commented 25 July 2013 at 01:27

Issue summary:

View changes

clarifying

Comment #3

corey.aufang CreditAttribution: corey.aufang commented 11 May 2014 at 01:03

Issue summary:

View changes

People that have this issue: if you could try using drop in replacement oyejorge/less.php (http://lessphp.gpeasy.com/#integration-with-other-projects).

I don't know if this resolves the precision error that was experience by leafo/lessphp, but oyejorge/less.php is much more closely structured to less/less.js so maybe it matches precision behavior.

Comment #4

corey.aufang CreditAttribution: corey.aufang commented 11 May 2014 at 01:03

Version:	7.x-3.0	» 7.x-3.x-dev
Category:	Bug report	» Support request

Comment #5

duncan.moo CreditAttribution: duncan.moo commented 12 May 2014 at 10:17

Status:

Active

» Closed (fixed)

Thanks corey.aufang, and thanks for updating the documentation on the module page, I am sure you will also get to changing the README.txt too.

Subsequent to posting this I also discovered https://github.com/oyejorge/less.php which is a very active version of LESSPHP and resolves the issues I was having. The Wordpress module wp-less also switched to using oyejorge/less.php .

Comment #6

corey.aufang CreditAttribution: corey.aufang commented 12 May 2014 at 20:44

Component:	Miscellaneous	» Documentation
Category:	Support request	» Task
Status:	Closed (fixed)	» Needs work

Ah, yes, I need to update the README.

I'm glad that the new library resolved your issue with precision.

Also, in the future please don't mark an issue as closed. Just mark as "Fixed" if it's a support request issue that you created. Otherwise, the issue disappears from the default filter on the issue queue.