User_access actually should have been marked as deprecated, when #1966334: Convert user_access to User::hasPermission() got in.

CommentFileSizeAuthor
#3 2045361-3.patch858 bytesfubhy
#1 user_access-2045361-1.patch902 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
user_access-2045361-1.patch902 bytes
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented 
+++ b/core/modules/user/user.moduleundefined
@@ -446,12 +446,15 @@ function _user_role_permissions_update($roles) {
+ *   Instead of user_access you should use:

Should have parens: user_access(). I'd also just say:
Instead of user_access(), use:

fubhy’s picture

fubhy CreditAttribution: fubhy commented
FileSize
2045361-3.patch858 bytes

Don't we have *this* as a standard? At least I've seen that all across core in that way.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Yes, I think that is correct. I doubt that the @code stuff would be parsed correctly.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed b3149b2 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.