Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The module should have a basic test that checks the submission of translation suggestions to a l10n server.
Comment | File | Size | Author |
---|---|---|---|
#3 | suggestion-submission-test-2045609-3.patch | 7.17 KB | s_leu |
#1 | suggestion-submission-test-2045609-1.patch | 6.52 KB | s_leu |
Comments
Comment #1
s_leu CreditAttribution: s_leu commentedHere's a first patch that uses mocking of the server response to test submissions.
Comment #2
BerdirNitpick: comments should be above the code.
refreshVariables() should be enough.
and
I don't think that assertTrue() is necessary/can fail. If anything, it would need to check $saved. But checking the specific properties should be enough I think.
Don't know enough about xml rpc to say if it's reliable to rely on the order. I assume they also have a name? then probably rely on that using Xpath.
Comment #3
s_leu CreditAttribution: s_leu commented"I assume they also have a name" No they don't. The output of the saved data looks like this:
I also added a test that checks if the translation gets stored locally.
Comment #4
BerdirTest looks good to me, let's enable testbot for commits/issues to see if this works there as well.
Comment #5
Gábor HojtsyEnabled testing for issues. Lets see if that kicks in here too :)
Comment #6
SebCorbin CreditAttribution: SebCorbin commented#3: suggestion-submission-test-2045609-3.patch queued for re-testing.
Comment #8
SebCorbin CreditAttribution: SebCorbin commentedRe-rolled and committed, thanks!