Follow up for #2042143: [META] Fix unsafe core translatable strings
Problem/Motivation
As said in the follow up issue, some strings cannot be translated due to the locale_string_is_safe
function. It is the case for the <Any>
string which can be chosen in the settings as a default value for exposed filters. Also, as discussed in #1317884: Remove all instances of <none>, <Hidden> and <br/> from translatable strings because they lead to import errors, we should improve string consistency on this kind of strings.
Proposed resolution
Remove all <Any>
and <Any>
strings in favor of - Any -
and also remove all stuff related by the choice of the label in views_ui.
Related issues
Cross reference : #2046533: End with "any" label configuration to improve consistency and localization
Credit
This issue was covered during the first Drupal Sprint of Montpellier (France).
Comment | File | Size | Author |
---|---|---|---|
#3 | drupal-views-remove_any_label_choice-2046537-3.patch | 3.78 KB | DuaelFr |
#1 | drupal-views-remove_any_label_choice-2046537-1.patch | 3.78 KB | DuaelFr |
Comments
Comment #1
DuaelFrHere is the patch !
Take care of the cross reference with #2046533: End with "any" label configuration to improve consistency and localization which is complementary.
Comment #1.0
DuaelFrfix html issues
Comment #2
DuaelFrMerged with #2046533: End with "any" label configuration to improve consistency and localization
Comment #3
DuaelFrOops !
Here is the merged patch.
This is the reference to the initial discussion about this kind of issues : https://drupal.org/node/1317884#comment-6976466
Comment #4
DuaelFrAdding VDC tag
Comment #5
dawehnerLet's make it consistent with the rest of Drupal core. I had a search and there was no test for it.
Comment #5.0
dawehnerAdded credit
Comment #6
alexpottCommitted 88cbedb and pushed to 8.x. Thanks!
Comment #7.0
(not verified) CreditAttribution: commentedPut
around to let it be unfiltered
Comment #8
hass CreditAttribution: hass commentedThis issue or #2046533: End with "any" label configuration to improve consistency and localization seems not fixed at all.
Under
admin/structure/views/settings
the suxxx<Any>
label is still in the select list and not only this - it is the default value.Comment #9
DuaelFr@hass It's a legacy setting. I agree we should remove it too. Let's do this in a follow-up issue: #2644584: Remove legacy setting allowing to use <Any> as default select value in Views exposed filters