When saving the content type for content translation the submit callback that saves the config is not executed. This is due to the fact that the primary submit function is attached to the button and not to the form array.

Edit_Article_content_type___d8dev.local_.png

CommentFileSizeAuthor
#3 drupal-unable-activate-content-translation-content-type-form-2046541-3.patch2.06 KBe0ipso
#1 drupal-unable-activate-content-translation-content-type-form-2046541-1-test-only.patch1.38 KBe0ipso
#1 drupal-unable-activate-content-translation-content-type-form-2046541-1.patch2.06 KBe0ipso
Edit_Article_content_type___d8dev.local_.png107.87 KBe0ipso
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented
Status: Active » Needs review
Issue tags: -Needs tests
FileSize
drupal-unable-activate-content-translation-content-type-form-2046541-1.patch2.06 KB
drupal-unable-activate-content-translation-content-type-form-2046541-1-test-only.patch1.38 KB

First attempt. Co-author: @plopesc

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Needs work
Issue tags: +sprint, +language-content

Wow, hum! Good find. Thanks for the fix. Also good test coverage. Only some English language picks:

+++ b/core/modules/content_translation/lib/Drupal/content_translation/Tests/ContentTranslationSettingsTest.phpundefined
@@ -101,6 +101,18 @@ function testSettingsUI() {
+    // Verify that the translation may be enabled for the article content type.

Remove "the" before "translation" to be better English :)

+++ b/core/modules/content_translation/lib/Drupal/content_translation/Tests/ContentTranslationSettingsTest.phpundefined
@@ -101,6 +101,18 @@ function testSettingsUI() {
+    // Make sure the checkbox is available and disabled by default.

"disabled" => "not checked" (disabled checkboxes cannot be checked :)

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented
FileSize
drupal-unable-activate-content-translation-content-type-form-2046541-3.patch2.06 KB

Update comments.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented
Status: Needs work » Needs review
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Looks good. Expected to pass as it did before.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

+1 to RTBC, thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 34aaed6 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint

Removing tag.