Add notes here.

CommentFileSizeAuthor
#15 sapi-unit_tests_statpluginmethodbase-2047321-15.patch12.84 KBiamEAP
#13 sapi-unit_tests_statmethod_storage_controller-2053423-13.patch12.85 KBiamEAP
#13 sapi-unit_tests_statmethod_storage_controller-2053423-13.interdiff.txt545 bytesiamEAP
#11 sapi-unit_tests_statpluginmethodbase-2047321-11.patch12.81 KBiamEAP
#7 sapi-unit_tests_statpluginmethodbase-2047321-7.patch12.19 KBiamEAP
#4 sapi-unit_tests-statpluginmethodbase-2047321-4.patch8.82 KBiamEAP
#3 sapi-unit_tests_statpluginmethodbase-2047321-3.patch6.87 KBiamEAP
#2 sapi-unit_tests_statpluginmethodbase-2047321-2.patch0 bytesiamEAP
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Component: Code » Stat methods

Reorganizing under "stat methods" component.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Status: Active » Needs work
FileSize
sapi-unit_tests_statpluginmethodbase-2047321-2.patch0 bytes

Here's a start. Still todo, tests for:

  • StatPluginMethodBase::manageData()
  • StatPluginmethodBase::collect()

Note PHPUnit for contrib is almost broken. This'll need #2025883: Drupal's PHPUnit bootstrap.php does not register module namespaces out of /core in order to run.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
FileSize
sapi-unit_tests_statpluginmethodbase-2047321-3.patch6.87 KB

By which, I of course mean...

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
FileSize
sapi-unit_tests-statpluginmethodbase-2047321-4.patch8.82 KB

Adding coverage for StatPluginmethodBase::collect() and cleaning up a number of other tests.

Still needs coverage on StatPluginMethodBase::manageData().

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Status: Needs work » Needs review

Setting "needs review" to illustrate the core bug referenced in #2.

Status: Needs review » Needs work

The last submitted patch, sapi-unit_tests-statpluginmethodbase-2047321-4.patch, failed testing.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Status: Needs work » Needs review
FileSize
sapi-unit_tests_statpluginmethodbase-2047321-7.patch12.19 KB

Full coverage of the base class; had to do some silly wrapping of watchdog because it's not an injectable service.

Status: Needs review » Needs work

The last submitted patch, sapi-unit_tests_statpluginmethodbase-2047321-7.patch, failed testing.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Status: Needs work » Needs review

#7: sapi-unit_tests_statpluginmethodbase-2047321-7.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, sapi-unit_tests_statpluginmethodbase-2047321-7.patch, failed testing.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Status: Needs work » Needs review
FileSize
sapi-unit_tests_statpluginmethodbase-2047321-11.patch12.81 KB

Getting rid of the wrapper class and using the getMockForAbstractClass method. Also making those config getter/setter methods to public.

Status: Needs review » Needs work

The last submitted patch, sapi-unit_tests_statpluginmethodbase-2047321-11.patch, failed testing.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Status: Needs work » Needs review
FileSize
sapi-unit_tests_statmethod_storage_controller-2053423-13.interdiff.txt545 bytes
sapi-unit_tests_statmethod_storage_controller-2053423-13.patch12.85 KB

Adding a "label" key.

Status: Needs review » Needs work

The last submitted patch, sapi-unit_tests_statmethod_storage_controller-2053423-13.patch, failed testing.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Status: Needs work » Needs review
FileSize
sapi-unit_tests_statpluginmethodbase-2047321-15.patch12.84 KB

Anywhere the watchdog() function is already defined, the associated constants will also already be defined... So here's this.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Status: Needs review » Fixed

Finally committed e8a5882 + @todos for removal once watchdog is injectable or something similar.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.