Problem

The skiplink is wrapped in a div with an id - thats against the guidelinies for the theme layer & is unnessary markup

<div id="skip-link">
   <a href="#main-content" class="visually-hidden focusable">
         {{ 'Skip to main content'|t }}
     </a>
 </div>

Proposed solution

proposed fix is to add the #skip-link to .skiplink & change the css accordingly in seven & bartik

 <a href="#main-content" class="visually-hidden focusable skip-link">
   {{ 'Skip to main content'|t }}
 </a>
CommentFileSizeAuthor
#3 kill-skip-link-divwrapper-2.diff3.71 KBmortendk
#1 kill-skip-link-divwrapper.diff3.72 KBmortendk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mortendk’s picture

mortendk CreditAttribution: mortendk commented
Status: Active » Needs review
FileSize
kill-skip-link-divwrapper.diff3.72 KB

and patch

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Needs work 
+++ b/core/modules/overlay/css/overlay-child.css
@@ -61,7 +61,7 @@ html[dir="rtl"] {
+.overlay .skip-link a {

This cannot work as the 'skip-link' class is now set on the anchor element. I guess you actually want a.skip-link :)

Same for everywhere in the patch.

mortendk’s picture

mortendk CreditAttribution: mortendk commented
FileSize
kill-skip-link-divwrapper-2.diff3.71 KB

Doh im an idiot ;)

fixed em thanx for the heads up

mortendk’s picture

mortendk CreditAttribution: mortendk commented
Status: Needs work » Needs review

bot get to work

mortendk’s picture

mortendk CreditAttribution: mortendk commented
Status: Needs review » Closed (duplicate)

doh this is a duplicate moving it to here #1982256: Clean up html.html.twig markup