Comments

Status:Needs review» Needs work

The last submitted patch, dont-use-function-exists.patch, failed testing.

Status:Needs work» Needs review

dont-use-function-exists.patch queued for re-testing.

  1. +++ b/core/lib/Drupal/Component/Utility/Crypt.php
    @@ -30,12 +30,9 @@ public static function randomBytes($count) {
    -      if (function_exists('getmypid')) {

    getmypid() is part of PHP4 and 5.

  2. +++ b/core/modules/color/color.module
    @@ -294,26 +294,24 @@ function color_scheme_form_submit($form, &$form_state) {
    -  if (function_exists('memory_get_usage')) {

    memory_get_usage() was added in PHP 5.2.

  3. +++ b/core/modules/simpletest/simpletest.install
    @@ -17,7 +17,6 @@ function simpletest_requirements($phase) {
    -  $has_hash = function_exists('hash_hmac');

    hash_hmac() was added in PHP 5.1.2.

dont-use-function-exists.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

See #3 for why this works.

dont-use-function-exists.patch queued for re-testing.

Status:Reviewed & tested by the community» Fixed

Committed ed11cb2 and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.