Hi All,

I found 2 issues in the code of search404.module:

1. Module uses 'core_search' as a parameter of apachesolr_search_page_load(). Because of this it doesn't work correctly when apachesolr uses another page as default.
2. The $search_path could have incorrect value, because value is not assigned to it in "else":

if (is_array($search_page)) {
  $search_path = $search_page['search_path'];
}
else {
  $search_page->search_path;
}

Both issues are fixed in attached patch. Hope it would be helpful.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitgoyal’s picture

Issue summary: View changes
Status: Needs review » Needs work

$ pwd
/var/www/d7/sites/all/modules/contrib/search404

$ git apply -v search404-code-issues.patch
Checking patch sites/all/modules/contrib/search404/search404.module...
error: sites/all/modules/contrib/search404/search404.module: No such file or directory

Looks like you need to create the patch from the search404 module folder.

anish_zyxware’s picture

Assigned: Unassigned » anish_zyxware
Status: Needs work » Reviewed & tested by the community
FileSize
1.15 KB

The patch no longer applies. New patch is generated.

anish_zyxware’s picture

Version: 7.x-1.3 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Closed (fixed)

The issue patch is applied and is on 7.x-1.x (development) branch.