navar-overlazy.png

ctools z-indexes at 1001, so we find ourselves in the way with navbar.

Screenshot

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Andrew_Mallis’s picture

Status: Active » Needs review
FileSize
505 bytes

attached is a patch that applies against dev

dsnopek’s picture

Status: Needs review » Reviewed & tested by the community

I am able to recreate the problem with manual testing, using the latest 7.x-1.x from Git. And applying the patch in #1 does fix the problem!

However, I have one question: Does it make sense to try and synchronize the z-index values used in Navbar with those in Toolbar in Drupal 8?

In D8's Toolbar (in toolbar.module.css) its:

.toolbar .toolbar-bar,
.toolbar .toolbar-tray {
  position: relative;
  z-index: 1250;
}

... and ...

.toolbar .toolbar-tray {
  display: none;
  z-index: 501;
}

So, they already differ (Navbar uses 1200 for something that's not unlike the 2nd example - although not exactly the same either). Not sure this really even matters.

Andrew_Mallis’s picture

comment in navbar.base.css seems to indicate the higher indexing's to circumvent some other core compatibility with contextual:

.drupal-navbar .horizontal {
  left: 0; /* LTR */
  height: 0;
  /* Set one higher than the contextual links gear. */
  z-index: 1000;
}

All for syncing things with core. I'm not so aware of what's what.

dsnopek’s picture

I also just realized that the reason the CSS is so different between Drupal 8 Toolbar and Navbar is because another patch didn't get backported yet: #2050699: Backport "Reduce dependency on JavaScript" from Drupal 8 toolbar

hass’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Looks like we no longer have this navbar base file. Please checkout latest DEV again.

jessebeach’s picture

Issue summary: View changes
Issue tags: +rc-blocker
jessebeach’s picture

Status: Postponed (maintainer needs more info) » Needs work
jessebeach’s picture

Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -rc-blocker
FileSize
58.63 KB

I think that recent refactoring has resolved this issue. When I test ctools modals, I see that the modal appears over the navbar.

yched’s picture

Issue summary: View changes
FileSize
179.63 KB

Z-indexes look fine, but the modal background doesn't extend to the left screen edge when the menu is open, you can still click in there :-)

hass’s picture

Status: Needs review » Closed (cannot reproduce)

Looks like the issue is resolved.