Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hitfactory’s picture

Patch attached.

Also flagging similar issue/patch for Drupal 6 here

hitfactory’s picture

Status: Active » Needs review
fenstrat’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, does what it says on the box, RTBC.

vijithaepa’s picture

Issue summary: View changes
FileSize
1.65 KB

There are should be "426", "452", "468" and "478" included as well.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: phone-au-mobile-rules-2050917-2.patch, failed testing.

peter.thorndycraft’s picture

Needed an update for this for our own setup. After reviewing this:

https://en.wikipedia.org/wiki/Telephone_numbers_in_Australia

I hope I am on the right track.

hamrant’s picture

Looks great, but file paths in the patch should not be from drupal docroot.

git apply phone-au-mobile-rules-2050917-6.patch
docroot/sites/all/modules/contrib/phone/include/phone.au.inc: No such file or directory
fenstrat’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @hamrant, #7 looks fine (no real need to wait for tests as this shouldn't effect anything there).