When I try to add an image URL for the slider it codes it with paragraphs tags surrounding it
ie

<img src="<p>/sites/localhost/files/slide-image-1_old.jpg</p>
" class="slide-image" alt="slider image 1">

As a result the image is not displayed. Also on the settings page after saving with an image URL it disappears from the form so in order to delete/change it you have to paste something else in then delete it.

Thanks!
Sharon

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mheinke’s picture

hmmm interesting,
i will take a look and fix asap.

v1adimir’s picture

That happens from
$slide1_img= check_markup(theme_get_setting('slide1_image_url','professional_theme'));

check_markup uses default input format. If the last has "convert linebrakes to br" selected – tadaaa! )

I am not sure is that right, but i rewrote this code to:
$slide1_img= check_plain(theme_get_setting('slide1_image_url','professional_theme'));

rgchi’s picture

I can confirm @v1adimir comment in #2 that by changing check_markup() to check_plain() in page.tpl.php, the images on the side show render properly.

rgchi’s picture

Status: Active » Needs review
FileSize
1.82 KB

Here is a patch for page.tpl.php.

Again, from comment #2, I've packaged this up in a patch to help move this along. Great start to this theme here. We'd love to use it.

rgchi’s picture

Issue summary: View changes

added code tag to see markup

mheinke’s picture

reviewing patch in #4 now, thank you @richardgoodrow

mheinke’s picture

Issue summary: View changes
Status: Needs review » Patch (to be ported)

adding to the next release

mheinke’s picture

Status: Patch (to be ported) » Closed (fixed)