Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When I try to add an image URL for the slider it codes it with paragraphs tags surrounding it
ie
<img src="<p>/sites/localhost/files/slide-image-1_old.jpg</p>
" class="slide-image" alt="slider image 1">
As a result the image is not displayed. Also on the settings page after saving with an image URL it disappears from the form so in order to delete/change it you have to paste something else in then delete it.
Thanks!
Sharon
Comment | File | Size | Author |
---|---|---|---|
#4 | professional_theme.user-interface.2051581-4.patch | 1.82 KB | rgchi |
Comments
Comment #1
mheinke CreditAttribution: mheinke commentedhmmm interesting,
i will take a look and fix asap.
Comment #2
v1adimir CreditAttribution: v1adimir commentedThat happens from
$slide1_img= check_markup(theme_get_setting('slide1_image_url','professional_theme'));
check_markup uses default input format. If the last has "convert linebrakes to br" selected – tadaaa! )
I am not sure is that right, but i rewrote this code to:
$slide1_img= check_plain(theme_get_setting('slide1_image_url','professional_theme'));
Comment #3
rgchi CreditAttribution: rgchi commentedI can confirm @v1adimir comment in #2 that by changing
check_markup()
tocheck_plain()
inpage.tpl.php
, the images on the side show render properly.Comment #4
rgchi CreditAttribution: rgchi commentedHere is a patch for page.tpl.php.
Again, from comment #2, I've packaged this up in a patch to help move this along. Great start to this theme here. We'd love to use it.
Comment #4.0
rgchi CreditAttribution: rgchi commentedadded code tag to see markup
Comment #5
mheinke CreditAttribution: mheinke commentedreviewing patch in #4 now, thank you @richardgoodrow
Comment #6
mheinke CreditAttribution: mheinke commentedadding to the next release
Comment #7
mheinke CreditAttribution: mheinke commented