Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
panopoly-admin.css harmonizes the content admin experience. Themes like Kalatheme and Radix leverage bootstrap, however, to provide consistent UI elements, so they disable panopoly-admin.css.
This has the unfortunate consequence of killing the panopoly icons in the navbar. Rather than redeclaring in these themes css that should live here, can we split the navbar css into its own file?
see: #2049867: Panopoly and Apps icons do not appear in the navbar
Comment | File | Size | Author |
---|---|---|---|
#11 | decouple_navbar_styling-2051621-11.patch | 6.7 KB | mglaman |
#7 | decouple_navbar_styling-2051621-7.patch | 2.11 KB | mglaman |
Comments
Comment #1
Andrew_Mallis CreditAttribution: Andrew_Mallis commentedWill you accept a patch?
Comment #2
populist CreditAttribution: populist commentedThat would be acceptable and thanks for asking. You are so considerate you must be a Canadian.
Comment #3
pirog CreditAttribution: pirog commentedThat is not how we would have done it in Mother Russia
Comment #4
Andrew_Mallis CreditAttribution: Andrew_Mallis commentedquick note here that:
Comment #5
liza CreditAttribution: liza commentedis there a patch forthcoming?
Comment #6
lsolesen CreditAttribution: lsolesen commentedWould be cool if @Andrew Mallis could create the patch :)
Comment #7
mglamanHere is patch to split up navbar tray customizations into panopoly-admin-navbar. +1 for this because I have my own contrib module which themes the navbar (Navbar Awesome) and this would conflict!
Comment #8
dsnopekThis may have an impact on Panopoly themes that are already doing something special to work around this. Can some open issues in Radix and Kalatheme explaining that updates may be necessary and link back here?
Otherwise, the patch looks good to me!
Comment #9
mglamanRadix: #2324607: Decoupled Navbar styling in Panopoly Admin
Kalatheme: https://github.com/drupalprojects/kalatheme/issues/136
Comment #10
dsnopekThanks, Matt! I was about to commit this, but it looks like some Navbar styling was missed. There's the icons at the bottom of the panopoly-admin.css too. Basically, everything under this comment should move:
Comment #11
mglamanUpdated patch with everything moved over.
Comment #13
dsnopekCommitted!
Comment #14
Andrew_Mallis CreditAttribution: Andrew_Mallis commentedyay!