We can get the status from the JSON: https://drupal.org/node/1068294/project-issue/json

CommentFileSizeAuthor
#3 patch_manager-2052175-add_status_tracking-3.patch13.97 KBPatchRanger
#1 patch_manager-2052175-add_status_tracking-1.patch10.84 KBPatchRanger
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented
Status: Active » Needs review
FileSize
patch_manager-2052175-add_status_tracking-1.patch10.84 KB

Done, please review.

aidanlis’s picture

aidanlis CreditAttribution: aidanlis commented
Status: Needs review » Needs work

Great work! Would you be able to change your approach slightly though? Instead of "hacking" into the view in post execute, you could achieve the same thing with a custom field formatter ... then you'd set the field formatter to "Drupal.org issue" and it'd grab the status / color the span. What do you think?

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented
Status: Needs work » Needs review
FileSize
patch_manager-2052175-add_status_tracking-3.patch13.97 KB

Nice shot! Here is the refactored patch.

aidanlis’s picture

aidanlis CreditAttribution: aidanlis commented

Looks amazing! Great job, please commit :)

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented
Status: Needs review » Patch (to be ported)

Fixed for 7.x: http://drupalcode.org/project/patch_manager.git/commit/f61c483 .

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Fixed

Fixed for D6 as well: http://drupalcode.org/project/patch_manager.git/commit/59be59d .

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.