Port Metatag to Drupal 8

We would need to get a planning session for update strategy. With a lot of the page rendering process changed, I am very worried about being able to output Metatags in the ways we expect to do so. As well as make sure to account for the newer D8 technologies like CMI.

As Core is stabilizing a bit more nowadays, I wonder if it makes sense to start the discussion again?

I don't recommend touching this until 8.0-beta1 is release, and I'm personally focusing on D7 for the foreseeable future.

If else anyone wants to work on this I'm happy to assist.

I would request this is work is postponed until 8.0-beta1 is out and this module has reached the 1.0 release.

Status for D8 is 3 beta blockers left and Damien said earlier this week that 1.0 might soon be released (pending performance work in https://www.drupal.org/node/2307383 I guess)

It seems reasonable to wait just a big longer. We're talking about 1 month maybe.

Dave mentioned in #8 that it would be useful to pause this until metatag-7.x-1.0 and drupal-8.0-beta1. Would this be an appropriate time to revisit this now that both milestones have been met?

Indeed it would. Anyone want to work on this?

@kim.pepper: I'd be completely satisfied with that - v1 as a "get it working" port, v2 as a "this is how it should work" cleanup.

Hi @kim.pepper. From the looks of it, the https://www.drupal.org/project/drupalmoduleupgrader module is still moving quickly to resolve a lot of open tickets, so it's possible that improvements coming down the pipeline might address the issues you were hitting in #15.

I'm not ready to dive in yet, but this module is on my wishlist as I'm starting to explore Drupal 8 a bit more. I'll let you know if it warrants gaining access (or just forking your copy outright).

PS, if it makes it easier:

• https://github.com/damienmckenna/metatag
• https://bitbucket.org/DamienMcKenna/metatag

@kim.pepper: You don't have to (it's git after all) but it might make some things easier for you, e.g. keeping up with changes in the D7 codebase.

wish I saw this topic earlier...
@kim.pepper: Have you done any work except for initial commit? Is it result of drupalmoduleupgrader?

I am working for some time on https://www.drupal.org/sandbox/valthebald/2339829, but of course, I'd prefer to join efforts with someone else, if the work is already in progress

FYI just to mention it, I'm expecting to start getting involved in this sometime in January.

@DamienMcKenna/@kim.pepper, I have granted you commit permissions to the sandbox project.

If someone else is going to work on this, it would be probably a good idea to start opening issues, at least for the big tasks (i.e. converting meta tag configuration to D8 configuration entities)

I'll be starting on this in the next week-or-two.

Would anyone be interested in having a hangout / skype chat to discuss this within the next two weeks?

I could in IRC.

IRC or hangout would be cool.

@DamienMcKenna *promoted* this on on Twitter just. I plan to use this module for a Drupal 8 project I'm about to startup now.

Will there be a need for supporting direct upgrading from a D7 site, or is that being easier to make now using Migrate in core?

I'm interested too. For me is better IRC too

IRC +1

irc+1

As I see there are 2 repos for porting of the metatag module to Drupal 8:
1. https://github.com/kimpepper/metatag
2. https://www.drupal.org/sandbox/valthebald/2339829
And https://github.com/damienmckenna/metatag as well.

Which one will be used for development now?

P.S: irc +1

FYI what I uploaded to github is a mirror of the main repo, and I also have one on bitbucket: https://bitbucket.org/DamienMcKenna/metatag

Please select one of the times on the following event invite:

• https://doodle.com/2t4s3bw953ten7s6

So far it seems that either Monday the 16th or Tuesday the 17th between noon and 2pm EST (5pm to 7pm GMT) would work for more people than the other times, the difference currently comes down to whether valthebald or mikey_p could make it. I'll follow up tomorrow and will make a decision then.

FYI I've changed the time options to only include when Dave Reid was available, please review the times and update your selection as appropriate. Thank you.

I can make it both on 16th and 17th on suggested hours (will update doodle now)

Ok, thank you all for letting me know when would work best for you. Based on the submissions I've picked this coming Monday, February 16th between noon and 2pm EST, i.e. between 5pm and 7pm GMT; you can download an icalendar file to add it to your calendar.

Lets plan to meet in the #drupal-seo channel on Freenode IRC.

I discovered that when drupal_set_title() was removed it was no longer possible to arbitrarily set the page title from a page a module does not control; we'll need to resolve #2121123: Introduce Drupal::formatTitle() as a replacement for drupal_set_title.

Another one: hook_page_build() was removed so we'll have to use either hook_page_attachments() or hook_page_attachments_alter(). Hopefully.

hook_page_attachments() should work fine for everything that uses #attached, yes, that's the only thing it can do. (and yes, html_head elements can be added through that, although the API is a bit strange)

FYI I've made a rough alpha-grade copy available:

• https://bitbucket.org/DamienMcKenna/metatag_d8

It doesn't do much, and there are a few todo items that we'll be dealing with early next week to fix some items, but it's a step in the right direction. Right now it *only* supports entities, check the README.txt file for the full todo list.

The D8 codebase is now able to output the page title, and has a number of other improvements since last week. Please feel free to poke it with a stick.

@ivanjaros: I wasn't able to replicate that problem using 8.0.0-beta9.

Apologies, there were some changes I had forgotten to upload to that repo. Please grab the latest and it should work.

@vincic: Not currently.

FYI I've uploaded some changes that fix two problems - Google+'s namespaces was throwing an error, and it was stomping all over any other module that needed to add page attachments.

I'm hoping to get to it later today to merge in some of the fixes that didn't (evidently) make it to the bitbucket repo, otherwise it'll be tomorrow morning. There hasn't been any further work (yet) but there have been some fixes. Also a few people have uploaded PRs on bitbucket, I'll look to reviewing & merging them.

@DamienMcKenna

Can you please keep the dev version here.

So that we can test help to improve speed of the development

I've uploaded the current codebase to the 8.x-1.x repository and am going to build out a list of issues to cover my current plans for the module. Assistance would be appreciated :)

I've put together some planning issues for the roadmap to 1.0 and beyond, starting with beta1: #2563605: Plan for Metatag 8.x-1.0-beta1 release

I've fleshed out a bunch of tasks that need to be done, with most of them assigned to a specific release plan.

I've also added a Trello board, if you'd like to see the plans on a kanban board: https://trello.com/b/V57H51X5/metatag-d8

I think post #65 has a lot of merit.

I've ported over two PRs provided by people on the old bitbucket repository, one from vincic and another from k9kiko, and another had been fixed in the original codebase already.

I've deleted the bitbucket repository in favor of the one here, but I have made the codebase available on github and bitbucket for people who would prefer to do PRs that upload patches:

• Primary repository: http://git.drupal.org/project/metatag.git
• Bitbucket: https://bitbucket.org/DamienMcKenna/metatag.git
• Github: https://github.com/damienmckenna/metatag.git

All changes will be added to the repository via d.o and then pushed out to the others. Any PRs uploaded to either Bitbucket or GitHub will be replicated as issues on d.o and then handled from there.

@ivanjros: Please consider what functionality is available for D7, then review the list of tasks for 1.0-beta1 through 1.0, and let me know which ones you don't think ought to be in 1.0.

@ivanjaros: The DrupalConsole integration will make it possible to generate new meta tags with a single command. I'm not releasing Metatag on D8 without it supporting the meta tags that are on D7, which the DrupalConsole will make a lot easier to do. And people who still think the "keywords" meta tag is relevant but don't know about Open Graph and Twitter Cards need to catch up on the last fifteen years of SEO practices.

FYI the backlog is things that I'm not planning on working on until after 1.2.

Just to make it clear - the items I've planned out indicate the order that I'm planning on approaching tasks, but if anyone wants to work on something and upload a patch I'd be extremely grateful.

+1
(cheers)

Hey guys,

I've tried to use the Drupal 8 Version of this module and noticed that if you add a Open Graph Image URL like "http://somesite.com/image.jpg" it gets changed to "http:/somesite.com/image.jpg" in the html preprocess step.

Responsible for that is this bit of code in src/MetatagToken.php:

65 // Ensure that there are no double-slash sequences due to empty token values.
66 $replaced = preg_replace('/\/+/', '/', $replaced);

Can someone please explain why double slashes are being removed? I don't really understand what the comment means.

Thanks!

@alex0412: Please open a bug report for that.

FYI we're currently working against beta15 right now, please keep that in mind while testing. That said, if you find a bug please open a new issue for it. Thanks!

My 2c - I'd put tests first, but that's just how I work. Adding them as an afterthought in RC1 may lead to regressions - adding them as functionality is ported will lead to improved stability.

Happy to help esp. with tests.

++ on tests. Happy to review the tests as well. I think @Sam152 can also help with tests I have seen him using a very good base class with metatag assertions.

I'd *really* appreciate patches for tests, please add them to #2563637: Write tests for the 8.x-1.x functionality. Thanks!

I've released beta1: https://www.drupal.org/node/2563605

Lets continue all further work in separate issues.

Thank you all for your patience and help!

(the package is being built, please give it a little while to finish)

@DamienMcKenna Wonderful thanks!

Thanks for porting this important SEO module. I am still getting the test phone number field in metatag settings, what's up with that - missing something? :)

BTW regarding D8 SEO, for some xml sitempa love, check out simple xml sitemap..

@gbyte.co: meta tags are fields now. The test phone number seems to be a placeholder for a global settings page

LOL, yes, that was a placeholder page we just haven't used yet.

@agoradesign: How would I go about setting global metatags / abstract as it was possible in the D7 version? Or is this feature not ported yet?

@gbyte.co: That part isn't done yet, it'll be handled in #2563639: Global configuration via config entities.

You guys should remove ..

"#D8CX: while there was initial work on porting metatags quick to Drupal 8, I encourage everyone who would like to help, join the effort with #2052441: Port Metatag to Drupal 8"

from the project page.

@darol100: That text isn't on the project page?

Wrong issue queue.... My bad... #90 was for meta tag quick.

Hiya Damein,

Congrats on migration of this important module.

Wasn't sure if this should have been a separate ticket or not, but I was just browsing the 8.x codebase and see metatags_panels is no longer around. What is the story there?

Also, other than the feature list on the project page, is there a document somewhere that talks about the differences between D7 and D8, and/or roadmap or features that will not be ported or features that are just no longer needed?

Thanks man.
James

Edit: I'll be happy to turn these into two separate questions on the issue queue if you'd prefer.

Hey there @jwilson3. Thanks for the comment.

Panels integration: #2563657: Panels / Page Manager integration
Comparison document: good idea, I've opened #2923406: Document the differences between D7, D8 versions

Awesome! Thanks for super fast response. 🎉

I'm still putting together a site audit for d7-d8 upgrade, when we get to implementation, will try to test the panels patch!