Hi,

I am seeing HTML in the log entry in watchdog when a user is notified of a comment. More precisely,

TYPE comment_notify
...
MESSAGE	Notified: <a href="/user/1/edit">aitala@psu.edu</a> 
...

This also shows up in the Message column in the Recent Log Messages page.

Its not a major issue, but its kind of annoying...

Eric

CommentFileSizeAuthor
#1 2053941-1-mail_nohtml.patch510 byteskscheirer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kscheirer’s picture

Version: 7.x-1.2 » 7.x-1.x-dev
Status: Active » Needs review
FileSize
510 bytes

Yeah, that's kind of annoying. Does this work?

cybermache’s picture

Issue summary: View changes

Should the previous line be wrapped in t() instead
? @@523,529

// Make the mail link to user's /edit, unless it's an anonymous user.
if ($alert->uid != 0) {
- $user_mail = l($mail, 'user/' . $alert->uid . '/edit');
+ $user_mail = t(l($mail, 'user/' . $alert->uid . '/edit'));
}
else {
$user_mail = check_plain($mail);
}

otherwise anonymous email doesn't get the check_plain?

UPDATE: didn't change a thing. Did this instead so anonymous users still go through the check_plain.

- $user_mail = l($mail, 'user/' . $alert->uid . '/edit');
+ $user_mail = $mail;