Follow up for #2054645: Restrict access to all admin/config/people/accounts/* and DS manage display

Now that admin/config/people/accounts/display is restricted, Display Suite is adding a primary tab on the user pages which redirects to admin/config/people/accounts/display. This menu item should be restricted too.

Patch coming.

CommentFileSizeAuthor
#12 user_settings_access-restrict_ds_manage_display_tab-2054679-12.patch637 bytesDuaelFr
#10 user_settings_access-restrict_ds_manage_display_tab-2054679-10.patch4.14 KBDuaelFr
#6 manage_display_link.png4.45 KBDuaelFr
#1 user_settings_access-restrict_ds_manage_display_tab-2054679-1.patch637 bytesDuaelFr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Assigned: DuaelFr » Unassigned
Status: Active » Needs review
FileSize
user_settings_access-restrict_ds_manage_display_tab-2054679-1.patch637 bytes
tchurch’s picture

tchurch CreditAttribution: tchurch commented

I will look at this patch over the weekend (hopefully) but my first comment would be that we need to use the new permission from the other issue (#2054645: Restrict access to all admin/config/people/accounts/* and DS manage display).
I would also need to check on Display Suite as I don't want to have dependencies to other modules.
If there's a way to do it without the dependency then I would look at that.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Assigned: Unassigned » tchurch

This patch does not introduce any dependency. It just checks if the DS menu item is set before to alter it.

tchurch’s picture

tchurch CreditAttribution: tchurch commented
Status: Needs review » Postponed (maintainer needs more info)

Can you provide more information. I don't see exactly which menu item you're trying to restrict.

tchurch’s picture

tchurch CreditAttribution: tchurch commented

Before this is committed you might also want to look at this module.

https://drupal.org/project/field_ui_permissions

It seems to do the same thing but for all entity types.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
manage_display_link.png4.45 KB

Scuse me for the delay it's holidays :)

The menu item I am trying to restrict is the one given by Display Suite on all entities wich allow a direct access to the Manage Display tab of the viewed entity's bundle.

manage_display_link.png

Thank you for the tip about Field UI permissions but I only need this on User entities and this module only restrict access to Fields settings, not to other User settings. I don't think that it would be a good idea to add another module just for this purpose...

Status: Needs review » Needs work

The last submitted patch, user_settings_access-restrict_ds_manage_display_tab-2054679-1.patch, failed testing.

tchurch’s picture

tchurch CreditAttribution: tchurch commented

The problem I now have is that this code change clashes with fields_ui_permissions. If both modules are active then fields_ui_permissions controls it and ignores this modules new setting. I'm trying to investigate it to see if there's a solution but not having a lot of luck (or time).
I would prefer if fields_ui_permissions did the work as it combines this check with other entity types too.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented

See my answer in the other issue : https://drupal.org/node/2054645#comment-7817907

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Status: Needs work » Needs review
FileSize
user_settings_access-restrict_ds_manage_display_tab-2054679-10.patch4.14 KB

Rerolled patch.

Status: Needs review » Needs work

The last submitted patch, user_settings_access-restrict_ds_manage_display_tab-2054679-10.patch, failed testing.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Status: Needs work » Needs review
FileSize
user_settings_access-restrict_ds_manage_display_tab-2054679-12.patch637 bytes

This one will apply when the #2096901: Apply coding standards issue will be close :)

Status: Needs review » Needs work

The last submitted patch, user_settings_access-restrict_ds_manage_display_tab-2054679-12.patch, failed testing.

kzsolt’s picture

kzsolt CreditAttribution: kzsolt commented
Status: Needs work » Needs review

12: user_settings_access-restrict_ds_manage_display_tab-2054679-12.patch queued for re-testing.

DuaelFr queued 12: user_settings_access-restrict_ds_manage_display_tab-2054679-12.patch for re-testing.

inno81’s picture

inno81 CreditAttribution: inno81 commented
Issue summary: View changes

This patch works for me!

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Assigned: tchurch » Unassigned
Category: Feature request » Bug report
Status: Needs review » Closed (duplicate)

Closing this in favour of #2054645: Restrict access to all admin/config/people/accounts/* and DS manage display.