CSS and JS should be added in hook_init [#2055759]

Between version 2.1 and 2.5 the directives to add the JS and CSS to the page were moved OUT of a hook_init function into a custom function. This breaks basic/core drupal themeing abilities and doesn't allow a theme a chance to override the CSS of the module by replicating the CSS files in the module (http://www.drupalcoder.com/blog/overriding-css-stylesheets-in-drupal-the...).

Comments

Comment #1

Perignon CreditAttribution: Perignon commented 1 August 2013 at 16:21

This function should be restored to follow drupal coding standards for themeing:

/**
 * Implements hook_init().
 *
 * We are adding the JavaScript and CSS here rather than theme_nice_menu
 * because when block caching is enabled none of it would get fired
 * and the menus are unstyled.
 */
function nice_menus_init() {
  // Add Superfish JavaScript, if enabled.
  if (variable_get('nice_menus_js', 1) == 1) {
    // The script, from http://users.tpg.com.au/j_birch/plugins/superfish.
    drupal_add_js(drupal_get_path('module', 'nice_menus') . '/superfish/js/superfish.js');
    // Add the Superfish options variables.
    drupal_add_js(array(
      'nice_menus_options' => array(
        'delay' => variable_get('nice_menus_sf_delay', 800),
        'speed' => variable_get('nice_menus_sf_speed', 1),
      ),
    ), array('type' => 'setting', 'scope' => JS_DEFAULT));
    // Add the bgIframe plugin.
    drupal_add_js(drupal_get_path('module', 'nice_menus') . '/superfish/js/jquery.bgiframe.min.js');
    // Add the HoverIntent plugin.
    drupal_add_js(drupal_get_path('module', 'nice_menus') . '/superfish/js/jquery.hoverIntent.minified.js');
    // The Nice menus implementation.
    drupal_add_js(drupal_get_path('module', 'nice_menus') . '/nice_menus.js');
  }

  // Add main CSS functionality.
  drupal_add_css(drupal_get_path('module', 'nice_menus') . '/nice_menus.css', array('group' => CSS_DEFAULT, 'basename' => 'nice_menus.css'));
  // Add custom CSS layout if specified.
  if ($custom = variable_get('nice_menus_custom_css', '')) {
    drupal_add_css($custom, array('group' => CSS_DEFAULT, 'basename' => 'nice_menus_custom.css'));
  }
  // Fall back to default layout.
  else {
    drupal_add_css(drupal_get_path('module', 'nice_menus') . '/nice_menus_default.css', array('group' => CSS_DEFAULT, 'basename' => 'nice_menus_default.css'));
  }
}

Comment #2

xiukun.zhou CreditAttribution: xiukun.zhou commented 2 August 2013 at 03:02

Status:

Active

» Needs review

thanks Perignon.
if move all js and css to hook_init. then will load nice_menu css and js in the all page.
@see #2020617: CSS Conflict: Path to custom Nice menus CSS file loads css file in admin theme

Comment #3

Perignon CreditAttribution: Perignon commented 7 August 2013 at 20:18

I bet if a use case analysis were done it would show that most every website using nice_menu's loads menu's on every page of the site. So that probably isn't that big of an issue.

This upgrade broke the CSS on my site when I performed the upgrade. Took me a few minutes to realize what happened when I finally dug into the module code to see that the hook_init was removed.